mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Milton Miller <miltonm@bga.com>
To: Hu Gang <hugang@soulinfo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fix oops in driver/serial/core.c
Date: Mon, 9 Jun 2003 01:18:14 -0500 (CDT)	[thread overview]
Message-ID: <200306090618.h596IEhX006480@sullivan.realtime.net> (raw)
In-Reply-To: <20030608211928.3d425b56.hugang@soulinfo.com>

How about the following patch instead, which preserves the reordering
done by Al Viro?

===== drivers/serial/core.c 1.62 vs edited =====
--- 1.62/drivers/serial/core.c	Fri Jun  6 01:36:47 2003
+++ edited/drivers/serial/core.c	Sun Jun  8 20:59:44 2003
@@ -2192,8 +2192,8 @@
 	drv->tty_driver = NULL;
 	tty_unregister_driver(p);
 	kfree(drv->state);
-	kfree(drv->tty_driver->termios);
-	kfree(drv->tty_driver);
+	kfree(p->termios);
+	kfree(p);
 }
 
 struct tty_driver *uart_console_device(struct console *co, int *index)

      reply	other threads:[~2003-06-09  6:05 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-08 13:19 hugang
2003-06-09  6:18 ` Milton Miller [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200306090618.h596IEhX006480@sullivan.realtime.net \
    --to=miltonm@bga.com \
    --cc=hugang@soulinfo.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®