From: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
To: "David S. Miller" <davem@redhat.com>
Cc: Matthew Wilcox <willy@debian.org>,
linux-kernel@vger.kernel.org, David Mosberger <davidm@hpl.hp.com>
Subject: Re: [PATCH] [3/3] PCI segment support
Date: Mon, 9 Jun 2003 14:42:42 +0400 [thread overview]
Message-ID: <20030609144242.A15283@jurassic.park.msu.ru> (raw)
In-Reply-To: <1055154054.9884.2.camel@rth.ninka.net>; from davem@redhat.com on Mon, Jun 09, 2003 at 03:20:56AM -0700
On Mon, Jun 09, 2003 at 03:20:56AM -0700, David S. Miller wrote:
> On Mon, 2003-06-09 at 03:07, Ivan Kokshaysky wrote:
> > Looks good, but shouldn't we pass 'struct pci_bus *' instead
> > of pci_dev to pci_domain_nr()?
>
> I don't think it matters, but someone may find a useful
> use of having the exact device available, who knows...
Hmm. Actually the patch *does* use pci_bus. What got me confused is
definition in include/linux/pci.h:
+#ifndef CONFIG_PCI_DOMAINS
+#define pci_domain_nr(pdev) 0
~~~~
+#endif
I think it should be changed to 'pbus' to avoid confusion.
> We could just pass the bus self device in this case.
Root buses often do not have the self device, e.g. on alpha.
Ivan.
next prev parent reply other threads:[~2003-06-09 10:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-04-07 23:44 Matthew Wilcox
2003-04-08 16:38 ` Ivan Kokshaysky
2003-04-08 16:50 ` Matthew Wilcox
2003-04-08 17:21 ` Ivan Kokshaysky
2003-04-08 17:31 ` Matthew Wilcox
2003-04-09 5:41 ` Grant Grundler
2003-06-08 16:43 ` Matthew Wilcox
2003-06-08 21:33 ` Russell King
2003-06-08 23:16 ` Alan Cox
2003-06-09 10:07 ` Ivan Kokshaysky
2003-06-09 10:20 ` David S. Miller
2003-06-09 10:42 ` Ivan Kokshaysky [this message]
2003-06-09 10:43 ` David S. Miller
2003-06-09 11:00 ` Ivan Kokshaysky
2003-06-09 11:04 ` David S. Miller
2003-06-09 11:17 ` Matthew Wilcox
2003-06-09 11:26 ` Ivan Kokshaysky
2003-06-09 14:34 ` Matthew Wilcox
2003-06-09 11:41 ` Ivan Kokshaysky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030609144242.A15283@jurassic.park.msu.ru \
--to=ink@jurassic.park.msu.ru \
--cc=davem@redhat.com \
--cc=davidm@hpl.hp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=willy@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®