mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@digeo.com>
To: boris mogwitz <boris@macbeth.rhoen.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: oops while booting : 2.5.70-bk1[4,5] - Process swapper
Date: Tue, 10 Jun 2003 14:30:18 -0700	[thread overview]
Message-ID: <20030610143018.025d318c.akpm@digeo.com> (raw)
In-Reply-To: <20030610202947.GA752@macbeth.rhoen.de>

boris mogwitz <boris@macbeth.rhoen.de> wrote:
>
> Unable to handle kernel NULL pointer dereference at virtual address 00000000
> ...
> 
> Trace; c0254888 <pcibios_enable_device+28/30>
> Trace; c01c4f7b <pci_enable_device_bars+2b/40>
> Trace; c01c4fa7 <pci_enable_device+17/20>
> Trace; c02466e9 <matroxfb_probe+d9/2d0>
> Trace; c01c6222 <pci_device_probe_static+52/70>
> Trace; c01c63bc <__pci_device_probe+3c/50>
> Trace; c01c63ff <pci_device_probe+2f/50>
> Trace; c01ee395 <bus_match+45/80>
> Trace; c01ee41f <device_attach+4f/90>
> Trace; c01ee5d5 <bus_add_device+65/b0>
> Trace; c01ed661 <device_add+d1/100>
> Trace; c032632c <pci_bus_add_devices+ac/e0>
> Trace; c0326315 <pci_bus_add_devices+95/e0>
> Trace; c0326e22 <pci_scan_bus_parented+42/50>
> Trace; c0330cbb <pcibios_scan_root+6b/80>
> Trace; c0330648 <pci_legacy_init+38/60>
> Trace; c031694b <do_initcalls+2b/a0>
> Trace; c012f27f <init_workqueues+f/24>
> Trace; c01050d8 <init+58/200>
> Trace; c0105080 <init+0/200>
> Trace; c0107229 <kernel_thread_helper+5/c>

pcibios_irq_init() _must_ run before pcibios_enable_device().  But they are
both at subsys_initcall(), so we are at the mercy of link order, which 
appears to be incorrect.

Does this fix it?


diff -puN arch/i386/pci/irq.c~pci-init-ordering-fix arch/i386/pci/irq.c
--- 25/arch/i386/pci/irq.c~pci-init-ordering-fix	Tue Jun 10 14:29:40 2003
+++ 25-akpm/arch/i386/pci/irq.c	Tue Jun 10 14:29:40 2003
@@ -791,7 +791,7 @@ static int __init pcibios_irq_init(void)
 	return 0;
 }
 
-subsys_initcall(pcibios_irq_init);
+arch_initcall(pcibios_irq_init);
 
 
 void pcibios_penalize_isa_irq(int irq)

_


  reply	other threads:[~2003-06-10 21:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-10 20:29 boris mogwitz
2003-06-10 21:30 ` Andrew Morton [this message]
2003-06-10 23:51   ` Andrew Morton
2003-06-12  0:19     ` Greg KH
2003-06-12  1:05       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030610143018.025d318c.akpm@digeo.com \
    --to=akpm@digeo.com \
    --cc=boris@macbeth.rhoen.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®