From: Andrew Morton <akpm@digeo.com>
To: Robert Love <rml@tech9.net>
Cc: bos@serpentine.com, linux-kernel@vger.kernel.org, piggin@cyberone.com.au
Subject: Re: [patch] as-iosched divide by zero fix
Date: Wed, 11 Jun 2003 18:22:49 -0700 [thread overview]
Message-ID: <20030611182249.0f1168e4.akpm@digeo.com> (raw)
In-Reply-To: <1055380257.662.8.camel@localhost>
Robert Love <rml@tech9.net> wrote:
>
> Fix as-iosched divide-by-zero bug.
hrm, OK. Still not convinced about `batch'.
How about this?
--- 25/drivers/block/as-iosched.c~as-div-by-zero-fix 2003-06-11 18:17:04.000000000 -0700
+++ 25-akpm/drivers/block/as-iosched.c 2003-06-11 18:20:58.000000000 -0700
@@ -930,13 +930,12 @@ void update_write_batch(struct as_data *
write_time = 0;
if (write_time > batch + 5 && !ad->write_batch_idled) {
- if (write_time / batch > 2)
+ if (write_time > batch * 2)
ad->write_batch_count /= 2;
else
ad->write_batch_count--;
-
} else if (write_time + 5 < batch && ad->current_write_count == 0) {
- if (batch / write_time > 2)
+ if (batch > write_time * 2)
ad->write_batch_count *= 2;
else
ad->write_batch_count++;
_
next prev parent reply other threads:[~2003-06-12 1:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 22:17 2.5.70-mm8: freeze after starting X Bryan O'Sullivan
2003-06-11 22:36 ` Robert Love
2003-06-11 22:41 ` Andrew Morton
2003-06-11 22:53 ` Bryan O'Sullivan
2003-06-11 23:11 ` Bryan O'Sullivan
2003-06-11 23:34 ` Robert Love
2003-06-12 0:18 ` Robert Love
2003-06-12 0:24 ` Andrew Morton
2003-06-12 1:10 ` [patch] as-iosched divide by zero fix Robert Love
2003-06-12 1:22 ` Andrew Morton [this message]
2003-06-12 1:28 ` Robert Love
2003-06-12 1:41 ` Nick Piggin
2003-06-12 1:31 ` Nick Piggin
2003-06-12 2:34 ` John Stoffel
2003-06-12 4:05 ` Nick Piggin
2003-06-12 1:22 ` Nick Piggin
2003-06-12 1:29 ` Robert Love
2003-06-12 1:54 ` Steven Cole
2003-06-12 2:01 ` Robert Love
2003-06-12 17:19 ` 2.5.70-mm8: freeze after starting X Bryan O'Sullivan
2003-06-12 17:29 ` Bryan O'Sullivan
2003-06-12 17:30 ` Davide Libenzi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030611182249.0f1168e4.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=bos@serpentine.com \
--cc=linux-kernel@vger.kernel.org \
--cc=piggin@cyberone.com.au \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®