From: Pavel Machek <pavel@ucw.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: kernel list <linux-kernel@vger.kernel.org>, torvalds@transmeta.com
Subject: Re: Messing up driver model API
Date: Thu, 12 Jun 2003 12:41:42 +0200 [thread overview]
Message-ID: <20030612104142.GB139@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.44.0306111407370.11379-100000@cherise>
Hi!
> > So you just had to mess it up... Having suspend(device *, state,
> > level) might be bad, but having suspend(device *, state, level) in one
> > piece of code and {suspend,save}(device *, state) is *way* worse. (And
> > I did not see any proposal on l-k. I hope I just missed it).
>
> Calm down, Pavel. From a technical standpoint, it's a superior
> interface.
>From a technical standpoint, its now mess with half a kernel using one
interface and second one using another. And you did not bother to mail
the patch to l-k for the review :-(, and then you call me a troll.
> > So are you going to revert it or convert whole driver model to use
> > {suspend,save}(device *, state)?
>
> Today: neither. I'm going to see how this works, and if it does, then I
> may convert all the users of struct device_driver to use the same
> model.
So we are stuck with the mess in 2.6; not good.
Pavel
--
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]
prev parent reply other threads:[~2003-06-12 10:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-11 20:36 Pavel Machek
2003-06-11 21:21 ` Patrick Mochel
2003-06-12 10:41 ` Pavel Machek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030612104142.GB139@elf.ucw.cz \
--to=pavel@ucw.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@osdl.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®