From: Andi Kleen <ak@suse.de>
To: mikpe@csd.uu.se
Cc: ak@suse.de, linux-kernel@vger.kernel.org, pavel@suse.cz
Subject: Re: [PATCH][2.5.71] x86-64 apic/nmi cleanups
Date: Mon, 16 Jun 2003 17:25:54 +0200 [thread overview]
Message-ID: <20030616152554.GH26583@wotan.suse.de> (raw)
In-Reply-To: <16109.56877.239305.852139@gargle.gargle.HOWL>
On Mon, Jun 16, 2003 at 05:11:41PM +0200, mikpe@csd.uu.se wrote:
> Andi,
>
> The driver model conversion left x86-64's apic.c and nmi.c with
> obsolete #includes and comments, and some poor code formatting.
Most of this is already in the patchkit.
>
> nmi.c also lacks the 'nmi_pm_active' change which went into
> i386 recently. It's needed to prevent enabling the watchdog
> after resume if it was disabled before suspend: this happens
> if another driver has claimed the HW and disabled the watchdog.
> This won't hit until you remove the #if 0 in lapic_nmi_resume(),
> however. (Why do you need that?)
I think it came from Pavel. I will remove it for now and merged that
change.
-Andi
prev parent reply other threads:[~2003-06-16 15:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-16 15:11 mikpe
2003-06-16 15:25 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030616152554.GH26583@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mikpe@csd.uu.se \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®