From: Stelian Pop <stelian.pop@fr.alcove.com>
To: Michael Buesch <fsdeveloper@yahoo.de>
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.4.21] meye driver update
Date: Mon, 16 Jun 2003 17:36:57 +0200 [thread overview]
Message-ID: <20030616153657.GA26958@hottah.alcove-fr> (raw)
In-Reply-To: <200306161654.52825.fsdeveloper@yahoo.de>
On Mon, Jun 16, 2003 at 04:54:41PM +0200, Michael Buesch wrote:
> > Unused of ix86 because bus addresses are the same as virtual addresses.
> > This is not however the case on other architetures, see
> > Documentation/DMA-mapping.txt.
>
> Yes, I now understand, why it is in 2.5, but isn't it better,
> to remove these parameters from your patch, because it is only
> a local copy in your driver and not used by any other drivers.
> And your driver is (if I didn't miss something) for running on
> i386 only; there is no other version of this function for
> other architectures, that need these parameters.
> So wouldn't it be better to simply remove them, because
> they are completely useless. IMHO their
> just confusing.
No, I hope that the DMA allocation function will be backported in the
near future from 2.5 into 2.4. If I get some time, I may even do it
myself and propose a patch.
And when it's done, I'll just have to remove the two definitions
without changing anything in my code and it will just work.
Besides, having two versions (2.4 and 2.5) which don't diverge to much
is much easier for the maintainer.
Stelian.
--
Stelian Pop <stelian.pop@fr.alcove.com>
Alcove - http://www.alcove.com
prev parent reply other threads:[~2003-06-16 15:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-15 16:31 Stelian Pop
2003-06-15 17:06 ` Michael Buesch
2003-06-15 21:29 ` Stelian Pop
2003-06-16 6:05 ` Stelian Pop
2003-06-16 14:54 ` Michael Buesch
2003-06-16 15:36 ` Stelian Pop [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030616153657.GA26958@hottah.alcove-fr \
--to=stelian.pop@fr.alcove.com \
--cc=fsdeveloper@yahoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®