mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: viro@parcelfarce.linux.theplanet.co.uk
To: Adrian Bunk <bunk@fs.tum.de>
Cc: Kernel Mailing List <linux-kernel@vger.kernel.org>,
	trivial@rustcorp.com.au, Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [2.5 patch] 2.5.72: moxa.c doesn't compile
Date: Wed, 18 Jun 2003 00:33:54 +0100	[thread overview]
Message-ID: <20030617233354.GW6754@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <20030617192929.GB26107@fs.tum.de>

On Tue, Jun 17, 2003 at 09:29:29PM +0200, Adrian Bunk wrote:
 
> The following patch fixes it. Additionally, it kills two unused 
> variables. I've tested the compilation with 2.5.72.
 
Thanks.  Linus, apply it, please.

> --- linux-2.5.72/drivers/char/moxa.c.old	2003-06-17 21:22:23.000000000 +0200
> +++ linux-2.5.72/drivers/char/moxa.c	2003-06-17 21:26:56.000000000 +0200
> @@ -339,7 +339,6 @@
>  {
>  	int i, n, numBoards;
>  	struct moxa_str *ch;
> -	int ret1, ret2;
>  
>  	printk(KERN_INFO "MOXA Intellio family driver version %s\n", MOXA_VERSION);
>  	moxaDriver = alloc_tty_driver(MAX_PORTS + 1);
> @@ -615,7 +614,7 @@
>  	}
>  	ch->asyncflags |= ASYNC_CLOSING;
>  
> -	ch->cflag = *tty->termios->c_cflag;
> +	ch->cflag = tty->termios->c_cflag;
>  	if (ch->asyncflags & ASYNC_INITIALIZED) {
>  		setup_empty_event(tty);
>  		tty_wait_until_sent(tty, 30 * HZ);	/* 30 seconds timeout */

  reply	other threads:[~2003-06-17 23:20 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-14 21:17 Linux 2.5.71 Linus Torvalds
2003-06-15  1:42 ` Florin Iucha
2003-06-15  1:58   ` Linus Torvalds
2003-06-15  2:00     ` Florin Iucha
2003-06-15  4:55       ` Florin Iucha
2003-06-15  8:03     ` Trond Myklebust
2003-06-15  6:54 ` Andre Hedrick
2003-06-15  7:15   ` Andre Hedrick
2003-06-15 13:29 ` Paweł Gołaszewski
2003-06-15 13:45   ` Russell King
2003-06-16 18:04 ` John Cherry
2003-06-17 19:29 ` [2.5 patch] 2.5.72: moxa.c doesn't compile Adrian Bunk
2003-06-17 23:33   ` viro [this message]
2003-06-19 18:53   ` Thiago Rondon
2003-06-20  4:28     ` Rusty Russell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030617233354.GW6754@parcelfarce.linux.theplanet.co.uk \
    --to=viro@parcelfarce.linux.theplanet.co.uk \
    --cc=bunk@fs.tum.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@transmeta.com \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®