From: Andi Kleen <ak@suse.de>
To: "Adam J. Richter" <adam@yggdrasil.com>
Cc: ak@suse.de, linux-kernel@vger.kernel.org
Subject: Re: 2.5.72 x86-generic missing enable_apic_mode()
Date: Wed, 18 Jun 2003 10:44:52 +0200 [thread overview]
Message-ID: <20030618084452.GD23037@wotan.suse.de> (raw)
In-Reply-To: <200306180827.h5I8Rtl27217@freya.yggdrasil.com>
On Wed, Jun 18, 2003 at 01:27:55AM -0700, Adam J. Richter wrote:
> x86-generic in 2.5.72 does not compile, because
> include/asm-i386/mach-generic/mach_apic.h does not define
> enable_apic_mode(). Although I kludged around this, by
> just defining enable_apic_mode() as nothing (since it is
> apparently nothing for all x86 platforms except es7000),
> I imagine that the correct definition is
>
> #define enable_apic_mode (genapic->enable_apic_mode)
>
> ...along with some other changes to declare
> genapic->enable_apic_mode and initialize it for each platform
> type.
It should be enough to add it to the genapic structure in
asm-i386/genapic.h and also to the APIC_INIT macro in the same file.
(assuming that it is properly defined for default,bigsmp,summit)
-Andi
next prev parent reply other threads:[~2003-06-18 8:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-18 8:27 Adam J. Richter
2003-06-18 8:44 ` Andi Kleen [this message]
2003-06-18 9:11 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030618084452.GD23037@wotan.suse.de \
--to=ak@suse.de \
--cc=adam@yggdrasil.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®