From: viro@parcelfarce.linux.theplanet.co.uk
To: John Stoffel <stoffel@lucent.com>
Cc: Linus Torvalds <torvalds@transmeta.com>,
linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [PATCH CYCLADES 1/2] fix cli()/sti() for ISA Cyclom-Y boards
Date: Wed, 18 Jun 2003 23:43:23 +0100 [thread overview]
Message-ID: <20030618224323.GE6754@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <16112.56865.325452.254827@gargle.gargle.HOWL>
On Wed, Jun 18, 2003 at 05:48:17PM -0400, John Stoffel wrote:
> - save_flags(flags); cli();
> + spin_lock_irqsave(&isa_card_lock, flags);
>
> if ((e1 = tty_unregister_driver(cy_serial_driver)))
> printk("cyc: failed to unregister Cyclades serial driver(%d)\n",
> e1);
>
> - restore_flags(flags);
> + spin_unlock_irqrestore(&isa_card_lock,flags);
It doesn't fix the problem and only makes the compile trouble go away.
Not to mention anything else, you are relying on a lot of code being
non-blocking.
Could you explain what is protected by disabling interrupts and taking
a spinlock here?
next prev parent reply other threads:[~2003-06-18 22:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-18 21:48 John Stoffel
2003-06-18 22:43 ` viro [this message]
2003-06-19 1:05 ` John Stoffel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030618224323.GE6754@parcelfarce.linux.theplanet.co.uk \
--to=viro@parcelfarce.linux.theplanet.co.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=stoffel@lucent.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®