From: Rusty Russell <rusty@rustcorp.com.au>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: frible@teaser.fr, linux-kernel@vger.kernel.org,
linux-net@vger.kernel.org, alan@lxorguk.ukuu.org.uk,
jgarzik@pobox.com
Subject: Re: [2.5 patch] yam.c: return IRQ_NONE in error case
Date: Fri, 20 Jun 2003 14:34:42 +1000 [thread overview]
Message-ID: <20030620050950.1A9A82C09A@lists.samba.org> (raw)
In-Reply-To: Your message of "Fri, 20 Jun 2003 02:01:38 +0200." <20030620000137.GG29247@fs.tum.de>
In message <20030620000137.GG29247@fs.tum.de> you write:
> Please check whether the following patch to return IRQ_NONE in case of
> errors is correct:
>
> --- linux-2.5.72-mm2/drivers/net/hamradio/yam.c.old 2003-06-20 01:57:02.000000000 +0200
> +++ linux-2.5.72-mm2/drivers/net/hamradio/yam.c 2003-06-20 01:57:41.000000000 +0200
> @@ -742,7 +742,7 @@
>
> if (--counter <= 0) {
> printk(KERN_ERR "%s: too many irq iir=%d\n", dev->name, iir);
> - return;
> + return IRQ_NONE;
> }
IRQ_HANDLED, I think: it did handle them, but decided it was
livelocked and exited.
Cheers,
Rusty.
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
next prev parent reply other threads:[~2003-06-20 4:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-20 0:01 Adrian Bunk
2003-06-20 4:34 ` Rusty Russell [this message]
2003-06-21 23:36 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030620050950.1A9A82C09A@lists.samba.org \
--to=rusty@rustcorp.com.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=bunk@fs.tum.de \
--cc=frible@teaser.fr \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-net@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®