From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S261168AbTFTE4K (ORCPT <rfc822;willy@w.ods.org>);
	Fri, 20 Jun 2003 00:56:10 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261365AbTFTEz7
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Fri, 20 Jun 2003 00:55:59 -0400
Received: from dp.samba.org ([66.70.73.150]:4326 "EHLO lists.samba.org")
	by vger.kernel.org with ESMTP id S261411AbTFTEzt (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 20 Jun 2003 00:55:49 -0400
From: Rusty Russell <rusty@rustcorp.com.au>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org, linux-net@vger.kernel.org,
       trivial@rustcorp.com.au
Subject: Re: [2.5 patch] remove an unused variable from xirc2ps_cs.c 
In-reply-to: Your message of "Fri, 20 Jun 2003 02:10:49 +0200."
             <20030620001049.GI29247@fs.tum.de> 
Date: Fri, 20 Jun 2003 14:36:01 +1000
Message-Id: <20030620050950.38D362C129@lists.samba.org>
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

In message <20030620001049.GI29247@fs.tum.de> you write:
> The platch below removes an unused variable from 
> drivers/net/pcmcia/xirc2ps_cs.c .

Please add __attribute_used__ instead, since the author presumably
wants the string left in.

Cheers,
Rusty.

> --- linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c.old	2003-06-20 02:07:40.000000000 +0200
> +++ linux-2.5.72-mm2/drivers/net/pcmcia/xirc2ps_cs.c	2003-06-20 02:07:55.000000000 +0200
> @@ -225,9 +225,7 @@
>  #else
>  #define DEBUG(n, args...)
>  #endif
> -static char *version =
> -"xirc2ps_cs.c 1.31 1998/12/09 19:32:55 (dd9jn+kvh)";
> -	    /* !--- CVS revision */
> +
>  #define KDBG_XIRC KERN_DEBUG   "xirc2ps_cs: "
>  #define KERR_XIRC KERN_ERR     "xirc2ps_cs: "
>  #define KWRN_XIRC KERN_WARNING "xirc2ps_cs: "
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.