From: Andrew Morton <akpm@digeo.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] page cache readahead implemented?
Date: Sun, 22 Jun 2003 16:04:31 -0700 [thread overview]
Message-ID: <20030622160431.3e94369b.akpm@digeo.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0306222314500.1177-100000@localhost.localdomain>
Hugh Dickins <hugh@veritas.com> wrote:
>
> On Sun, 22 Jun 2003, Andrew Morton wrote:
> > Hugh Dickins <hugh@veritas.com> wrote:
> > >
> > > do_mmap_pgoff's PROT_EXEC do_page_cache_readahead assumes that is
> > > implemented for all mappings, but not all filesystems provide ->readpage.
> >
> > Which filesystems?
>
> No prize for guessing it was tmpfs I found the problem with.
Yeah, the usual blot on the kernelscape.
> Am I reading alloc_inode correctly, that the default it gives is
> an empty_aops with NULL readpage, but a backing_dev_info with non-0
> ra_pages? How does your do_mmap_pgoff fare on a PROT_EXEC mapping
> of one of those mmaping device drivers?
Probably explodes? I'm not particularly serious about that change - it
can be done in userspace.
Is the do_mmap_pgoff() hack the only offender? If so it would be better to
localise the test in there too.
next prev parent reply other threads:[~2003-06-22 22:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-22 18:27 Hugh Dickins
2003-06-22 18:41 ` Andrew Morton
2003-06-22 22:29 ` Hugh Dickins
2003-06-22 23:04 ` Andrew Morton [this message]
2003-06-23 5:38 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030622160431.3e94369b.akpm@digeo.com \
--to=akpm@digeo.com \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®