From: Christoph Hellwig <hch@infradead.org>
To: Andries.Brouwer@cwi.nl
Cc: hch@infradead.org, linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] loop.c - part 1 of many
Date: Mon, 23 Jun 2003 09:44:04 +0100 [thread overview]
Message-ID: <20030623094404.A3427@infradead.org> (raw)
In-Reply-To: <UTC200306230840.h5N8eWY10820.aeb@smtp.cwi.nl>; from Andries.Brouwer@cwi.nl on Mon, Jun 23, 2003 at 10:40:32AM +0200
On Mon, Jun 23, 2003 at 10:40:32AM +0200, Andries.Brouwer@cwi.nl wrote:
> Why do you think that might be a good idea? General elegance?
> The array is legacy only - it will not grow.
> It has length 20, and only three entries are frequently used:
> 18 for CryptoAPI, 16 for loopAES, 0 for no encryption.
Having fixed arrays for extenions is generally a bad design, yes.
Also selection of those extensions by magic number is very very bad,
IMHO we should replace it with a by-name selection before any other
transformation is added to the kernel so we can just special-case the
existing two onesand stop worrying about magic numbers.
next prev parent reply other threads:[~2003-06-23 8:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-23 8:40 Andries.Brouwer
2003-06-23 8:44 ` Christoph Hellwig [this message]
-- strict thread matches above, loose matches on Subject: below --
2003-06-23 8:59 Andries.Brouwer
2003-06-23 14:17 ` Christoph Hellwig
2003-06-23 8:47 Andries.Brouwer
2003-06-23 8:49 ` Christoph Hellwig
2003-06-23 1:27 Andries.Brouwer
2003-06-23 1:47 ` viro
2003-06-23 5:21 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030623094404.A3427@infradead.org \
--to=hch@infradead.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®