From: Greg KH <greg@kroah.com>
To: Adrian Bunk <bunk@fs.tum.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [2.5 patch] fix buggy comparison in cpqphp_pci.c
Date: Mon, 23 Jun 2003 15:19:14 -0700 [thread overview]
Message-ID: <20030623221914.GB11244@kroah.com> (raw)
In-Reply-To: <20030621142153.GU29247@fs.tum.de>
On Sat, Jun 21, 2003 at 04:21:53PM +0200, Adrian Bunk wrote:
> Hi Greg,
>
> I don't understand the code good enough to be sure my patch is correct,
> but the current code is definitely buggy:
>
> 0xFF is the maximum value for an u8, so tdevice < 0x100 is _always_
> true.
Nice catch, I've applied this.
thanks,
greg k-h
prev parent reply other threads:[~2003-06-23 22:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-21 14:21 Adrian Bunk
2003-06-23 22:19 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030623221914.GB11244@kroah.com \
--to=greg@kroah.com \
--cc=bunk@fs.tum.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®