From: Adrian Bunk <bunk@fs.tum.de>
To: bcollins@debian.org, linux1394-devel@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org
Subject: 2.5.73: eth1394.c: ptask might be used uninitialized
Date: Tue, 24 Jun 2003 19:22:55 +0200 [thread overview]
Message-ID: <20030624172254.GQ3710@fs.tum.de> (raw)
In 2.5.73, gcc complains as follows:
<-- snip -->
...
CC drivers/ieee1394/eth1394.o
...
drivers/ieee1394/eth1394.c:1424: warning: `ptask' might be used
uninitialized in this function
...
<-- snip -->
It seems something like the patch below might be needed (I didn't check
for 100% correctness, but it shows what might be needed to fix it).
cu
Adrian
--- linux-2.5.73-not-full/drivers/ieee1394/eth1394.c.old 2003-06-23 23:11:01.000000000 +0200
+++ linux-2.5.73-not-full/drivers/ieee1394/eth1394.c 2003-06-23 23:11:25.000000000 +0200
@@ -1427,7 +1427,7 @@
if (skb_is_nonlinear(skb)) {
ret = skb_linearize(skb, kmflags);
if(ret)
- goto fail;
+ goto out;
}
ptask = kmem_cache_alloc(packet_task_cache, kmflags);
@@ -1555,6 +1555,7 @@
ether1394_free_packet(ptask->packet);
if(ptask)
kmem_cache_free(packet_task_cache, ptask);
+out:
if(skb != NULL) {
dev_kfree_skb(skb);
}
next reply other threads:[~2003-06-24 17:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-24 17:22 Adrian Bunk [this message]
2003-06-24 17:49 ` Steve Kinneberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030624172254.GQ3710@fs.tum.de \
--to=bunk@fs.tum.de \
--cc=bcollins@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®