mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@fs.tum.de>
To: Cciss-discuss@lists.sourceforge.net
Cc: linux-kernel@vger.kernel.org, trivial@rustcorp.com.au
Subject: [2.5 patch] postfix a constant in cciss.c with ULL
Date: Tue, 24 Jun 2003 19:30:32 +0200	[thread overview]
Message-ID: <20030624173032.GT3710@fs.tum.de> (raw)

The patch below postfixes a constant in cciss.h with ULL, on 32 bit
archs this constant is too big for an int.

The cast doesn't do the right thing, 0xffffffffffffffff is in C an int 
and the cast casts 0xffffffffffffffff interpreted as an int to an u64.

Please apply
Adrian

--- linux-2.5.73-not-full/drivers/block/cciss.c.old	2003-06-23 21:35:15.000000000 +0200
+++ linux-2.5.73-not-full/drivers/block/cciss.c	2003-06-23 21:36:07.000000000 +0200
@@ -2457,7 +2457,7 @@
 	hba[i]->pdev = pdev;
 
 	/* configure PCI DMA stuff */
-	if (!pci_set_dma_mask(pdev, (u64) 0xffffffffffffffff))
+	if (!pci_set_dma_mask(pdev, 0xffffffffffffffffULL))
 		printk("cciss: using DAC cycles\n");
 	else if (!pci_set_dma_mask(pdev, 0xffffffff))
 		printk("cciss: not using DAC cycles\n");

                 reply	other threads:[~2003-06-24 17:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030624173032.GT3710@fs.tum.de \
    --to=bunk@fs.tum.de \
    --cc=Cciss-discuss@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=trivial@rustcorp.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®