mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: James Bottomley <James.Bottomley@steeleye.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
	Kai Germaschewski <kai@tp1.ruhr-uni-bochum.de>
Subject: Re: [PATCH] fix in-kernel genksyms for parisc symbols
Date: Wed, 25 Jun 2003 16:02:31 +1000	[thread overview]
Message-ID: <20030625061924.3D1272C28B@lists.samba.org> (raw)
In-Reply-To: Your message of "23 Jun 2003 18:27:43 EST." <1056410864.1826.57.camel@mulgrave>

In message <1056410864.1826.57.camel@mulgrave> you write:
> The problem is that the parisc libgcc.a library contains symbols that
> look like $$mulI and the like, but genksyms doesn't think $ is legal for
> a function symbol, so they all get dropped from the output.  This means
> that inserting almost any module on parisc taints the kernel because
> these symbols have no version.
> 
> The fix (attached below) was to allow $ in an identifier in lex.l (and
> obviously to update the _shipped files as well, but my flex/bison seem
> to be rather different from the one they were generated with, so I'll
> leave that to whomever has the correct versions).

Looks fine, but my flex is different, too.  Kai?

Cheers,
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

===== scripts/genksyms/lex.l 1.2 vs edited =====
--- 1.2/scripts/genksyms/lex.l	Wed Feb 19 16:42:13 2003
+++ edited/scripts/genksyms/lex.l	Mon Jun 23 17:17:17 2003
@@ -37,7 +37,7 @@
 
 %}
 
-IDENT			[A-Za-z_][A-Za-z0-9_]*
+IDENT			[A-Za-z_\$][A-Za-z0-9_\$]*
 
 O_INT			0[0-7]*
 D_INT			[1-9][0-9]*

  reply	other threads:[~2003-06-25  6:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-23 23:27 James Bottomley
2003-06-25  6:02 ` Rusty Russell [this message]
2003-06-25 20:22   ` Kai Germaschewski
2003-06-29 22:18     ` David Weinehall
2003-07-02 15:24       ` Kai Germaschewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030625061924.3D1272C28B@lists.samba.org \
    --to=rusty@rustcorp.com.au \
    --cc=James.Bottomley@steeleye.com \
    --cc=kai@tp1.ruhr-uni-bochum.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®