From: Christoph Hellwig <hch@infradead.org>
To: Lou Langholtz <ldl@aros.net>
Cc: Andrew Morton <akpm@digeo.com>,
linux-kernel@vger.kernel.org, pavel@ucw.cz
Subject: Re: [RFC][PATCH] nbd driver for 2.5+: fix locking issues with ioctl UI
Date: Wed, 25 Jun 2003 16:55:13 +0100 [thread overview]
Message-ID: <20030625165513.A20328@infradead.org> (raw)
In-Reply-To: <3EF9C192.7000206@aros.net>; from ldl@aros.net on Wed, Jun 25, 2003 at 09:36:50AM -0600
On Wed, Jun 25, 2003 at 09:36:50AM -0600, Lou Langholtz wrote:
> I have also attached a patch to Pavel's nbd-2.0 release nbd tools that
> updates the nbd-client to work with linux 2.5 as well as 2.5.74
> (assuming the aforementioned patch 6.1 made it into 2.5.74). Handling is
> switched at compile time however and uses <linux/version.h> to do the
> switching. This will have problems of course if the builder doesn't pay
> close attention to where there header file are coming from or tries to
> run the same binary on a different kernel release. Etc.
That's broken. You must make sure that a binary works with different
kernels or at least make it fail gracefully. Using <linux/version.h>
from userspace is absolutely not acceptable, just don't use kernel headers
at all but a local copy of <linux/nbd.h>.
next prev parent reply other threads:[~2003-06-25 15:41 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-25 6:51 Lou Langholtz
2003-06-25 7:19 ` Andrew Morton
2003-06-25 14:24 ` Lou Langholtz
2003-06-25 15:36 ` Lou Langholtz
2003-06-25 15:55 ` Christoph Hellwig [this message]
2003-06-25 17:38 ` Lou Langholtz
2003-06-25 17:44 ` Christoph Hellwig
2003-06-25 18:16 ` Lou Langholtz
2003-06-25 18:19 ` Christoph Hellwig
2003-06-25 17:58 ` Anyone for NBD maintainer [was Re: [RFC][PATCH] nbd driver for 2.5+: fix locking issues with ioctl UI] Pavel Machek
2003-06-25 18:21 ` Lou Langholtz
2003-06-25 18:30 ` Pavel Machek
2003-06-25 21:35 ` Lou Langholtz
[not found] ` <Pine.LNX.4.10.10306251645580.11076-100000@clements.sc.steeleye.com>
2003-06-25 21:09 ` NBD maintainer change [was Re: Anyone for NBD maintainer] Pavel Machek
2003-06-25 17:48 ` [RFC][PATCH] nbd driver for 2.5+: fix locking issues with ioctl UI Paul Clements
2003-06-25 17:56 ` viro
2003-06-25 18:57 ` Lou Langholtz
2003-06-25 19:41 ` Lou Langholtz
2003-06-25 20:00 ` Paul Clements
2003-06-25 22:17 ` Lou Langholtz
2003-06-28 17:13 ` Paul Clements
2003-06-30 16:10 ` Lou Langholtz
2003-06-28 17:20 ` [PATCH] nbd: maintain compatibility with existing nbd tools Paul Clements
2003-06-29 18:42 ` Pavel Machek
2003-06-29 21:04 ` [PATCH 2.5.73] " Paul Clements
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030625165513.A20328@infradead.org \
--to=hch@infradead.org \
--cc=akpm@digeo.com \
--cc=ldl@aros.net \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®