mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Samium Gromoff <deepfire@ibe.miee.ru>
To: linux-kernel@vger.kernel.org
Cc: sct@redhat.com, akpm@digeo.com, axboe@suse.de
Subject: [BIO] request->flags ambiguity
Date: Fri, 27 Jun 2003 13:47:56 +0400	[thread overview]
Message-ID: <20030627134756.4118617e.deepfire@ibe.miee.ru> (raw)

	I might just be completely off base, but something struck me lately as odd, and i`d
	like to hear what you folks think about the issue.

	I`m wondering about the ambiguity of the struct request->flags field.

	Is it ok to have a possibility of a request with conflicting meanings attached to it?
	For example REQ_CMD | REQ_PM_SHUTDOWN | REQ_SPECIAL.

	It may be, depending on the implementation, that they are not completely
	conflicting, but its hard to believe that there is zero ambiguity at all.

	If i`m not mistaken this looks as creating opportunities for various subtle bugs.

	Shouldn`t it make more sense to separate request-type-indicator flags
	into a separate unambiguous type field, which would take
	one of the following values:
		- read/write request
		- sense query
		- power control
		- special request

	And not a currently possible combination of all of them, which seem to be the
	current situation.

-- 
regards, Samium Gromoff

             reply	other threads:[~2003-06-27 10:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-27  9:47 Samium Gromoff [this message]
2003-06-27 10:48 ` Jens Axboe
2003-06-27 10:28   ` Samium Gromoff
2003-06-27 11:29     ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030627134756.4118617e.deepfire@ibe.miee.ru \
    --to=deepfire@ibe.miee.ru \
    --cc=akpm@digeo.com \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®