From: Matthew Wilcox <willy@debian.org>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Linux FSdevel <linux-fsdevel@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
NFS maillist <nfs@lists.sourceforge.net>
Subject: Re: [PATCH 1/4] Optimize NFS open() calls by means of 'intents'...
Date: Mon, 30 Jun 2003 16:14:26 +0100 [thread overview]
Message-ID: <20030630151426.GG31618@parcelfarce.linux.theplanet.co.uk> (raw)
In-Reply-To: <16128.19197.159225.698080@charged.uio.no>
On Mon, Jun 30, 2003 at 04:36:45PM +0200, Trond Myklebust wrote:
> +++ linux-2.5.73-04-lookupintent/include/linux/namei.h 2003-06-30 08:48:43.000000000 +0200
> struct nameidata {
> struct dentry *dentry;
> struct vfsmount *mnt;
> struct qstr last;
> unsigned int flags;
> int last_type;
> +
> + /* Intent data */
> + union {
> + struct open_intent open;
> + } u;
> +
> +#if 0
> + /* FS private data */
> + void *it_private;
> + void (*it_release)(struct nameidata *, void *);
> +#endif
Can we call the union something descriptive (eg "intent") rather than "u"?
"u" only makes sense when you're working around not having anonymous
unions.
--
"It's not Hollywood. War is real, war is primarily not about defeat or
victory, it is about death. I've seen thousands and thousands of dead bodies.
Do you think I want to have an academic debate on this subject?" -- Robert Fisk
next prev parent reply other threads:[~2003-06-30 15:00 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-06-30 14:36 Trond Myklebust
2003-06-30 15:14 ` Matthew Wilcox [this message]
2003-07-01 9:39 ` Trond Myklebust
-- strict thread matches above, loose matches on Subject: below --
2003-06-30 14:37 Trond Myklebust
2003-06-30 14:39 ` Trond Myklebust
2003-05-23 12:45 Trond Myklebust
2003-05-23 16:23 ` Linus Torvalds
2003-05-23 17:59 ` viro
2003-05-23 18:32 ` Andreas Dilger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030630151426.GG31618@parcelfarce.linux.theplanet.co.uk \
--to=willy@debian.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®