mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Attila Kinali <kinali@gmx.net>
To: axboe@suse.de
Cc: linux-kernel@vger.kernel.org
Subject: cdrom blocksize reset bug with 2.4.x kernels
Date: Wed, 2 Jul 2003 00:25:58 +0200	[thread overview]
Message-ID: <20030702002558.7faf6c88.kinali@gmx.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 1212 bytes --]

Hi,

After some discussion on the mplayer-users mailinglist about
that for some scsi drives it's impossible to read a data cd
after reading a vcd/scvd until the next reboot.
(see http://mplayerhq.hu/pipermail/mplayer-users/2002-December/025696.html)

I found that there is a reset of the cdrom block size needed
for those drives which doesnt restet it themselfs if a new
cd is put in (looks like only a few scsi cdroms are affected)

Attached is a small patch for drivers/cdrom/cdrom.c that fixes 
this for the 2.4.20 kernel (and also for 2.4.21 as the code didn't
change). It's reseting the blocksize when a cdrom is opened for
the first time (meaning that a umount/mount cycle can reset
the blocksize).

I run this code now for about half a year and didnt have any problems.
But, as i didnt get any feadback from other people, i'm not sure if
everything is correct.

Greetings
			Attila Kinali

-- 
Emacs ist für mich kein Editor. Für mich ist das genau das gleiche, als wenn
ich nach einem Fahrrad (für die Sonntagbrötchen) frage und einen pangalaktischen
Raumkreuzer mit 10 km Gesamtlänge bekomme. Ich weiß nicht, was ich damit soll.
		-- Frank Klemm, de.comp.os.unix.discussion

[-- Attachment #2: cdrom-blocksize.patch --]
[-- Type: application/octet-stream, Size: 509 bytes --]

--- cdrom.c.orig	2003-01-05 15:02:53.000000000 +0100
+++ cdrom.c	2003-01-05 15:05:44.000000000 +0100
@@ -475,7 +475,15 @@
 	else
 		ret = open_for_data(cdi);
 
-	if (!ret) cdi->use_count++;
+	if (!ret)
+	{
+		cdi->use_count++;
+		if(cdi->use_count == 1)
+		{
+			/* reset blocksize in case it's wrong */
+			cdrom_switch_blocksize(cdi,CD_FRAMESIZE);
+		}
+	}
 
 	cdinfo(CD_OPEN, "Use count for \"/dev/%s\" now %d\n", cdi->name, cdi->use_count);
 	/* Do this on open.  Don't wait for mount, because they might

             reply	other threads:[~2003-07-01 22:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-01 22:25 Attila Kinali [this message]
2003-07-02 11:18 ` Jens Axboe
2003-11-09 14:56   ` Tobias Diedrich
2003-11-12 16:06     ` Tobias Diedrich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030702002558.7faf6c88.kinali@gmx.net \
    --to=kinali@gmx.net \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®