From: Andrew Morton <akpm@osdl.org>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: Paul.Clements@SteelEye.com, akpm@digeo.com,
linux-kernel@vger.kernel.org,
viro@parcelfarce.linux.theplanet.co.uk
Subject: Re: [PATCH 2.5.74-mm2] nbd: make nbd and block layer agree about device and block sizes
Date: Sun, 6 Jul 2003 15:03:33 -0700 [thread overview]
Message-ID: <20030706150333.28d61f4d.akpm@osdl.org> (raw)
In-Reply-To: <3F0896E4.4070003@pobox.com>
Jeff Garzik <jgarzik@pobox.com> wrote:
>
> Also, I wonder if you found a bug/oversight in set_blocksize -- it sets
> bd_inode->i_blkbits but not bd_inode->i_size. I think it should set
> i_size also. Maybe Andrew or Al can confirm/refute this assertion.
set_blocksize() sets, err, the blocksize.
Lou was wanting to export bd_set_size() for setting i_size. But
bd_set_size() goes and tries to set the blocksize too.
So the patch as-is will do I think, unless someone feels there's a need to
go and rework these things.
prev parent reply other threads:[~2003-07-06 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-06 21:15 [PATCH 2.5.74-mm2] nbd: remove unneeded nbd_open/nbd_release and refcnt Paul Clements
2003-07-06 21:20 ` [PATCH 2.5.74-mm2] nbd: make nbd and block layer agree about device and block sizes Paul Clements
2003-07-06 21:38 ` Jeff Garzik
2003-07-06 21:55 ` Paul Clements
2003-07-06 22:02 ` Jeff Garzik
2003-07-06 22:03 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030706150333.28d61f4d.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Paul.Clements@SteelEye.com \
--cc=akpm@digeo.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®