From: Andrew Morton <akpm@osdl.org>
To: Chris Mason <mason@suse.com>
Cc: schlicht@uni-mannheim.de, green@namesys.com, barryn@pobox.com,
piggin@cyberone.com.au, linux-kernel@vger.kernel.org
Subject: Re: [BUG] heavy disk access sometimes freezes 2.5.73-mm[123]
Date: Mon, 7 Jul 2003 12:18:59 -0700 [thread overview]
Message-ID: <20030707121859.5204703f.akpm@osdl.org> (raw)
In-Reply-To: <1057599193.20904.1352.camel@tiny.suse.com>
Chris Mason <mason@suse.com> wrote:
>
> > diff -u linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c.orig linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c
> > --- linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c.orig 2003-06-23 09:26:10.000000000 -0700
> > +++ linux-2.5.74-mm2/fs/reiserfs/tail_conversion.c 2003-06-23 09:26:10.000000000 -0700
> > @@ -190,9 +190,6 @@ unmap_buffers(struct page *page, loff_t
> > }
> > bh = next ;
> > } while (bh != head) ;
> > - if ( PAGE_SIZE == bh->b_size ) {
> > - ClearPageDirty(page);
> > - }
> > }
> > }
> > }
>
> Heh, you read my mind. It makes more sense for this hunk to be causing
> problems than the first one. Still we should be allowed to clear the
> dirty bit since we've cleaned all the buffers on the page.
But we need to tell the VFS that the page was cleaned.
Could someone please make that clear_page_dirty() and retest?
next prev parent reply other threads:[~2003-07-07 19:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-03 9:05 Barry K. Nathan
2003-07-06 20:46 ` Barry K. Nathan
2003-07-07 2:27 ` Nick Piggin
2003-07-07 2:37 ` Andrew Morton
2003-07-07 3:30 ` Barry K. Nathan
2003-07-07 15:58 ` Thomas Schlichter
2003-07-07 17:33 ` Chris Mason
2003-07-07 19:18 ` Andrew Morton [this message]
2003-07-07 23:47 ` Barry K. Nathan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030707121859.5204703f.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=barryn@pobox.com \
--cc=green@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=piggin@cyberone.com.au \
--cc=schlicht@uni-mannheim.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®