mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ravikiran G Thirumalai <kiran@in.ibm.com>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Remi Colinet <remi.colinet@wanadoo.fr>, linux-kernel@vger.kernel.org
Subject: Re: 2.5.74 / oops with ppp_synctty and local_bh_enable
Date: Tue, 8 Jul 2003 14:57:12 +0530	[thread overview]
Message-ID: <20030708092703.GA2099@llm08.in.ibm.com> (raw)
In-Reply-To: <001601c3449f$1e49d5b0$0c00a8c0@diemos>

On Mon, Jul 07, 2003 at 10:47:48AM -0500, Paul Fulghum wrote:
> ... 
> Perhaps changing ppp_synctty.c to use spin_lock_irqsave
> and spin_lock_irqrestore is the best fix.

My 2 cents would be to keep it as it is.  BK says WARN_ON was used
in place of BUG_ON in local_bh_enable just for the the ppp ldisc.  

We all know tty locking is broken and needs rewrite, but 
if we kill such symptoms at driver level, it'll probably deprive
some data points to whoever rewrites the tty layer.

Thanks,
Kiran

      reply	other threads:[~2003-07-08  9:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-06 14:01 Rémi Colinet
2003-07-07 15:47 ` Paul Fulghum
2003-07-08  9:27   ` Ravikiran G Thirumalai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030708092703.GA2099@llm08.in.ibm.com \
    --to=kiran@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulkf@microgate.com \
    --cc=remi.colinet@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®