From: Marc-Christian Petersen <m.c.p@wolk-project.de>
To: trond.myklebust@fys.uio.no
Cc: Marcelo Tosatti <marcelo@conectiva.com.br>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: ->direct_IO API change in current 2.4 BK
Date: Wed, 9 Jul 2003 20:55:41 +0200 [thread overview]
Message-ID: <200307092055.41863.m.c.p@wolk-project.de> (raw)
In-Reply-To: <16140.25619.963866.474510@charged.uio.no>
On Wednesday 09 July 2003 20:50, Trond Myklebust wrote:
Hi Trond,
> So they have both XFS + NFS O_DIRECT?
yes.
> The answer to your question is then that somebody made the trivial
> conversion on XFS... It's just a question of replacing the second
> argument of the direct_IO() method with a filp, then extracting the
> inode from that. A 2-liner patch at most...
EXACT! That was my intention with my small first post ;)
> The point here is that Marcelo's tree does not include XFS, so my
> patch can't fix it up...
> As I said, I suggest replacing KERNEL_HAS_O_DIRECT with
> KERNEL_HAS_O_DIRECT2 so that the XFS patches can switch on that, and
> hence provide the 2-liner on newer kernels...
It's very okay with me.
ciao, Marc
next prev parent reply other threads:[~2003-07-09 18:41 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-09 12:31 Christoph Hellwig
2003-07-09 17:03 ` Andreas Dilger
2003-07-09 17:24 ` Marcelo Tosatti
2003-07-09 17:43 ` Marc-Christian Petersen
2003-07-09 17:46 ` Marcelo Tosatti
2003-07-09 17:55 ` Marc-Christian Petersen
2003-07-09 18:08 ` Marcelo Tosatti
2003-07-09 18:22 ` Marc-Christian Petersen
2003-07-09 19:13 ` Marcelo Tosatti
2003-07-09 19:45 ` Marc-Christian Petersen
2003-07-09 23:43 ` Alan Cox
2003-07-10 0:21 ` Jeff Garzik
2003-07-09 18:33 ` Trond Myklebust
2003-07-09 18:41 ` Marc-Christian Petersen
2003-07-09 18:50 ` Trond Myklebust
2003-07-09 18:55 ` Marc-Christian Petersen [this message]
2003-07-09 19:05 ` Jeff Garzik
2003-07-09 19:08 ` Trond Myklebust
2003-07-09 19:17 ` Jeff Garzik
2003-07-09 19:51 ` Trond Myklebust
2003-07-09 21:43 ` Jeff Garzik
2003-07-09 23:42 ` Alan Cox
2003-07-10 0:23 ` Jeff Garzik
2003-07-09 23:40 ` Alan Cox
2003-07-09 18:29 ` Trond Myklebust
2003-07-09 18:51 ` Andreas Dilger
2003-07-09 19:18 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200307092055.41863.m.c.p@wolk-project.de \
--to=m.c.p@wolk-project.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®