Re: [PATCH] add seq file helpers from 2.5 (fwd)

[Chris Wright <chris@wirex.com>]

* Chris Wright (chris@wirex.com) wrote:
> * Marcelo Tosatti (marcelo@conectiva.com.br) wrote:
> > +int single_open(struct file *file, int (*show)(struct seq_file *, void*), void *data)
> > +{
> > +	struct seq_operations *op = kmalloc(sizeof(*op), GFP_KERNEL);
> > +	int res = -ENOMEM;
> > +
> > +	if (op) {
> > +		op->start = single_start;
> > +		op->next = single_next;
> > +		op->stop = single_stop;
> > +		op->show = show;
> > +		res = seq_open(file, op);
> 
> Any reason not to simply allocate static ops struct?  As in:

Bah, nevermind, I didn't look closely enough to see that show is
dynamic here (not to mention it is simple straight backport).  Sorry for
senseless noise ;-)

thanks,
-chris
-- 
Linux Security Modules     http://lsm.immunix.org     http://lsm.bkbits.net