mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Borzenkov <arvidjaar@mail.ru>
To: devfs@oss.sgi.com
Cc: linux-kernel@vger.kernel.org,
	Thierry Vignaud <tvignaud@mandrakesoft.com>
Subject: devfsd hangs on restart - is_devfsd_or_child() problem
Date: Fri, 11 Jul 2003 22:47:12 +0400	[thread overview]
Message-ID: <200307112247.12646.arvidjaar@mail.ru> (raw)

I cannot believe it is so fragile ...

is_devfsd_or_child() simplemindedly checks for pgrp:

static int is_devfsd_or_child (struct fs_info *fs_info)
{
    if (current == fs_info->devfsd_task) return (TRUE);
    if (current->pgrp == fs_info->devfsd_pgrp) return (TRUE);
    return (FALSE);
}   /*  End Function is_devfsd_or_child  */

unfortunately, bash (I do not know if it does it always or not) resets pgrp on 
startup. I.e. if your action is using shell it is no more considered devfsd 
descendant ... and it will attempt in turn start devfsd action while devfsd 
is waiting for it ot finish.

Thierry, i refer mostly to dynamics scripts currently. Every time I update 
devfsd it hangs in one of them. And actually it is enough to do service 
devfsd restart to trigger this. It may be 2.5 specific again in that it is 
not as easily seen under 2.4.

I have no idea what can be done. Is there any way in kernel to find out if one 
task is descendant of other task? Even rewriting devfsd to use non-blocking 
calls and request queue does not help as it apprently just results in endless 
loop (action triggering action triggering action ...)

-andrey

             reply	other threads:[~2003-07-11 18:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-11 18:47 Andrey Borzenkov [this message]
2003-07-12 10:11 ` [PATCH][2.5.75] " Andrey Borzenkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200307112247.12646.arvidjaar@mail.ru \
    --to=arvidjaar@mail.ru \
    --cc=devfs@oss.sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tvignaud@mandrakesoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®