From: "David S. Miller" <davem@redhat.com>
To: Jamie Lokier <jamie@shareable.org>
Cc: kuznet@ms2.inr.ac.ru, linux-kernel@vger.kernel.org
Subject: Re: [PATCH]: Set SOCK_DONE when TCP socket receives FIN
Date: Sun, 13 Jul 2003 19:56:06 -0700 [thread overview]
Message-ID: <20030713195606.0e913f8b.davem@redhat.com> (raw)
In-Reply-To: <20030714024100.GA23023@mail.jlokier.co.uk>
On Mon, 14 Jul 2003 03:41:00 +0100
Jamie Lokier <jamie@shareable.org> wrote:
> The SOCK_DONE flag is always clear and never set in 2.5.75. Yet there
> is code which tests it, and if it's clear, will return -ENOTCONN.
> Admittedly I am confused as to how this is not noticed :)
>
> This small patch sets it where it looks like it was intended.
> Please check.
Indeed, good catch. This bug got introduced when we changed
all of those volatile char things into a flags bitmask
(ChangeSet 1.889.291.25)
Patch applied, thanks.
prev parent reply other threads:[~2003-07-14 2:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-14 2:41 Jamie Lokier
2003-07-14 2:56 ` David S. Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030713195606.0e913f8b.davem@redhat.com \
--to=davem@redhat.com \
--cc=jamie@shareable.org \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®