From: "Herbert Pötzl" <herbert@13thfloor.at>
To: Jan Kara <jack@ucw.cz>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: Quota Hash Abstraction 2.4.22-pre6
Date: Wed, 16 Jul 2003 02:19:43 +0200 [thread overview]
Message-ID: <20030716001942.GA17459@www.13thfloor.at> (raw)
In-Reply-To: <20030715234507.GA25420@atrey.karlin.mff.cuni.cz>
Hi Honza!
On Wed, Jul 16, 2003 at 01:45:07AM +0200, Jan Kara wrote:
> >
> > this is the first step, and it is neither tuned for
~~~~~~~~~~~~~~~~~~~~~~~
> > performance nor the final implementation, it's just
> > a in-between step to some future quota enhancements
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> > like the folowing ...
> >
> > - faster and smaller quota hashes
> Actually I think we don't care too much about performance here - the
> number of dquots is rougly #active_users*#filesystems_with_quota and we
> do lookup only on open()...
hmm, actually we do the lookup in each dqget, which from
dquot_initialize (open), dquot_transfer (chown,chgrp),
and vfs_get_dqblk/vfs_set_dqblk (quota ctls) ...
but I agree that we do not care too much about performance ...
> > - not only per super_block hashes, maybe per vfsmount?
> For current quota you must have per super_block hashes. If you'd like
> to have some "directory based" one the per vfsmount makes sense.
exactly, this is one of the future quota enhancements,
I have in mind ... not exactly directory based, but more
vfsmount based ... (which includes the superblock case)
> > - not hardcoded user/group quota ...
> After a quick look I don't see any changes wrt this. What exactly do
> you mean by this?
as I wrote "first step", "future quota enhancements" ...
this hopefully will be in the next step, or the step after ...
> > - better interface for quota extensions
> >
> > please, if somebody has any quota tests, which he/she
> > is willing to do on this code, or just want to do some
> > testing with this code, do it and send me the results ...
> >
> > I'm not interested in getting this into 2.4 without
> Actually I don't think you'll be able to get some change like this to
> 2.4 but 2.6 might be possible.
at the moment, I do not care if this is for 2.4, 2.6
or 2.8 or for my personal tree ;) I just want to test
some of my ideas regarding quota improvements/extensions,
and the current design isn't flexible enough to allow it ...
> BTW: don't you need some locking on dqhash list when
> creating/destorying hashes?
I guess this is right, but I assume the kernel lock
will do nicely (any objections? if not I'll add that)
thanks for looking at it ... ;)
best,
Herbert
prev parent reply other threads:[~2003-07-16 0:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-15 16:40 Herbert Pötzl
2003-07-15 16:55 ` Herbert Pötzl
[not found] ` <20030715234507.GA25420@atrey.karlin.mff.cuni.cz>
2003-07-16 0:19 ` Herbert Pötzl [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030716001942.GA17459@www.13thfloor.at \
--to=herbert@13thfloor.at \
--cc=jack@ucw.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®