Re: woes with 2.6.0-test1 and xscreensaver/xlock

[Nuno Monteiro <nuno.monteiro@ptnix.com>]

[-- Attachment #1: Type: text/plain, Size: 674 bytes --]

On 2003.07.16 20:56, Nuno Monteiro wrote:
> 
> 
[bla bla bla snipped]

Replying to myself:

Ok, I figured it out. It's a definitely a pam problem. I fetched latest 
pam rpm from RH RawHide and picked up their sigchld patch, applied it to 
mandrake cookers's latest pam package, rebuilt, et voila'. All is well 
again, it doesnt hang anymore. I think the bug in bugzilla can be closed 
now. I'm attaching the patch to pam 0.77, if anyone wants to give it a 
spin. Also, should anyone from mandrake is reading this, it'd be 
adviseable to apply it to the official package. I'll ping them anyway, to 
let them know of this.

Thanks for the input, everyone.



Regards, 
		Nuno

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: pam-0.77-sigchld.patch --]
[-- Type: text/x-diff; charset=unknown-8bit, Size: 950 bytes --]

Specifying SIG_IGN for SIGCHLD (which by default, is ignored) is not the same
as specifying SIG_DFL.  See the NOTES section of wait(2) for the skinny on this.

--- Linux-PAM-0.77/modules/pam_pwdb/support.-c	2003-07-09 00:15:06.000000000 -0400
+++ Linux-PAM-0.77/modules/pam_pwdb/support.-c	2003-07-09 00:15:19.000000000 -0400
@@ -370,7 +370,7 @@
 	 * The "noreap" module argument is provided so that the admin can
 	 * override this behavior.
 	 */
-	sighandler = signal(SIGCHLD, SIG_IGN);
+	sighandler = signal(SIGCHLD, SIG_DFL);
     }
 
     /* fork */
--- Linux-PAM-0.77/modules/pam_unix/support.c	2003-07-09 00:15:29.000000000 -0400
+++ Linux-PAM-0.77/modules/pam_unix/support.c	2003-07-09 00:15:41.000000000 -0400
@@ -597,7 +597,7 @@
 	 * The "noreap" module argument is provided so that the admin can
 	 * override this behavior.
 	 */
-	sighandler = signal(SIGCHLD, SIG_IGN);
+	sighandler = signal(SIGCHLD, SIG_DFL);
     }
 
     /* fork */