mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Patrick Mochel <mochel@osdl.org>
Cc: Pavel Machek <pavel@ucw.cz>,
	torvalds@transmeta.com,
	kernel list <linux-kernel@vger.kernel.org>
Subject: Re: Make CONFIG_ACPI_SLEEP independend on CONFIG_SOFTWARE_SUSPEND
Date: Fri, 18 Jul 2003 11:12:52 +0200	[thread overview]
Message-ID: <20030718091252.GA280@elf.ucw.cz> (raw)
In-Reply-To: <Pine.LNX.4.33.0307171959270.876-200000@localhost.localdomain>

Hi!

> > This separates CONFIG_ACPI_SLEEP and CONFIG_SOFTWARE_SUSPEND. That
> > should end the user confusion. It also updates obsolete docs, and
> > makes code less noisy. Please apply,
> 
> Alright, I applied the initial patch to make those config options 
> independent, though with a slightly different take on it. 
> 
> I moved kernel/suspend.c to drivers/power/swsusp.c and extracted the 
> process suspension code to drivers/power/process.c. This removes the 
> #ifdef from swsusp.c. (drivers/power/process.c is compiled when CONFIG_PM 
> is set and drivers/power/swsusp.c only when CONFIG_SOFTWARE_SUSPEND is 
> set). 

I do not really like the placement; process suspension is not really a
device driver. What about kernel/power/*.c, instead?

Otherwise it looks good.
								Pavel

-- 
When do you have a heart between your knees?
[Johanka's followup: and *two* hearts?]

  parent reply	other threads:[~2003-07-18  8:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-17 21:12 Pavel Machek
2003-07-17 22:35 ` Patrick Mochel
     [not found] ` <Pine.LNX.4.33.0307171959270.876-200000@localhost.localdomain>
2003-07-18  9:12   ` Pavel Machek [this message]
2003-07-18 13:44     ` Patrick Mochel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030718091252.GA280@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mochel@osdl.org \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®