From: Francois Romieu <romieu@fr.zoreil.com>
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, khc@pm.waw.pl
Subject: [PATCH] 2.6.0-test2 - HDLC hook update for drivers/net/wan/dscc4
Date: Mon, 28 Jul 2003 21:04:27 +0200 [thread overview]
Message-ID: <20030728210427.B8054@electric-eye.fr.zoreil.com> (raw)
- ChangeSet 1.1525, 2003/07/25 15:24:04-07:00, khc@pm.waw.pl
[...]
- protocol hooks are slighty changed to allow zeroing (memset).
make: *** [drivers] Error 2
drivers/net/wan/dscc4.c: In function `dscc4_found1':
drivers/net/wan/dscc4.c:891: incompatible types in assignment
[...]
-> dscc4 module doesn't set hdlc->proto(.id) itself anymore.
- MOD_{INC/DEC}_USE_COUNT removal;
- SET_NETDEV_DEV() use;
drivers/net/wan/dscc4.c | 8 +++-----
1 files changed, 3 insertions(+), 5 deletions(-)
diff -puN drivers/net/wan/dscc4.c~drivers-hooks-changed-dscc4 drivers/net/wan/dscc4.c
--- linux-2.6.0-test2/drivers/net/wan/dscc4.c~drivers-hooks-changed-dscc4 Mon Jul 28 20:35:32 2003
+++ linux-2.6.0-test2-fr/drivers/net/wan/dscc4.c Mon Jul 28 20:46:52 2003
@@ -876,6 +876,8 @@ static int dscc4_found1(struct pci_dev *
d->do_ioctl = dscc4_ioctl;
d->tx_timeout = dscc4_tx_timeout;
d->watchdog_timeo = TX_TIMEOUT;
+ SET_MODULE_OWNER(d);
+ SET_NETDEV_DEV(d, &pdev->dev);
dpriv->dev_id = i;
dpriv->pci_priv = ppriv;
@@ -888,8 +890,7 @@ static int dscc4_found1(struct pci_dev *
printk(KERN_ERR "%s: unable to register\n", DRV_NAME);
goto err_unregister;
}
- hdlc->proto = IF_PROTO_HDLC;
- SET_MODULE_OWNER(d);
+
dscc4_init_registers(dpriv, d);
dpriv->parity = PARITY_CRC16_PR0_CCITT;
dpriv->encoding = ENCODING_NRZ;
@@ -955,8 +956,6 @@ static int dscc4_open(struct net_device
if ((ret = hdlc_open(hdlc)))
goto err;
- MOD_INC_USE_COUNT;
-
ppriv = dpriv->pci_priv;
if ((ret = dscc4_init_ring(dev)))
@@ -1015,7 +1014,6 @@ err_free_ring:
dscc4_release_ring(dpriv);
err_out:
hdlc_close(hdlc);
- MOD_DEC_USE_COUNT;
err:
return ret;
}
_
next reply other threads:[~2003-07-28 18:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-07-28 19:04 Francois Romieu [this message]
2003-07-28 19:22 ` [PATCH] 2.6.0-test2 - HDLC hook update for drivers/net/wan/pc300_drv.c Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030728210427.B8054@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®