mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: clepple@ghz.cc
Cc: linux-kernel@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>
Subject: Re: [REPOST] "apm: suspend: Unable to enter requested state" after 2.5.31 (incl. 2.6.0testX)
Date: Wed, 30 Jul 2003 11:05:48 +1000	[thread overview]
Message-ID: <20030730110548.73919ca0.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1059502242.5987.24.camel@dhcp22.swansea.linux.org.uk>

Hi Charles,

I may have missed this, but do you have the APIC or IO-APIC enabled?

The patch in question merely moved where the 0x40 descriptor was installed
in the descriptor table.

On 29 Jul 2003 19:10:42 +0100 Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > -static struct desc_struct      bad_bios_desc = { 0, 0x00409200 };
> > +static struct desc_struct      bad_bios_desc = { 0x00109300, 0x00409200 };
> >  static char                    driver_version[] = "1.16ac";    /* no
> > spaces */
> > 
> > I tried this on top of 2.6.0-test2, and it didn't work. Where does the
> > first number in that initializer come from?
> 
> I wasnt sure if the kernel code was initialising all the flag and control bits
> of the segment entry. That should have set the bits required anyway just in
> case if I got it right (Pentium pro dev manual vol III chapter 7)
> 
> It might be 0x00009300, it might be set already, or it might be some other
> effect thats breaking your laptop of course

The 0 above initialises the base and limit parts of the descriptor and
should be zero as it is filled in later (or should be).

The 0x00409200 means this is a byte granularity (0x800000 not present)
32-bit (0x400000) present (0x8000) memory (0x1000) read/write (0x200)
descriptor.  The 32-bit part should be irrelevent as this descriptor
should only be loaded into the DS register (that bit only affect code and
stack segments).

The base and limit parts of the descriptor get initialised at run time by
the code:

	set_base(bad_bios_desc, __va((unsigned long)0x40 << 4));
	_set_limit((char *)&bad_bios_desc, 4095 - (0x40 << 4));

These could be set statically, but it was easier to use the availble
macros.

-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

  reply	other threads:[~2003-07-30  1:06 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-07-29 14:50 Charles Lepple
2003-07-29 15:07 ` Alan Cox
2003-07-29 16:05   ` Charles Lepple
2003-07-29 18:10     ` Alan Cox
2003-07-30  1:05       ` Stephen Rothwell [this message]
2003-07-30  1:38         ` Charles Lepple
2003-07-30  2:21           ` Stephen Rothwell
2003-07-30 16:48             ` [REPOST] "apm: suspend: Unable to enter requested state" after2.5.31 " Charles Lepple
2003-07-30 14:43         ` [REPOST] "apm: suspend: Unable to enter requested state" after 2.5.31 " Alan Cox
2003-07-30 15:16           ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030730110548.73919ca0.sfr@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=clepple@ghz.cc \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®