From: Andrew Morton <akpm@osdl.org>
To: Andries Brouwer <aebr@win.tue.nl>
Cc: Andries.Brouwer@cwi.nl, linux-kernel@vger.kernel.org, torvalds@osdl.org
Subject: Re: i_blksize
Date: Mon, 4 Aug 2003 23:10:26 -0700 [thread overview]
Message-ID: <20030804231026.0d7251f2.akpm@osdl.org> (raw)
In-Reply-To: <20030805025846.GA4779@win.tue.nl>
Andries Brouwer <aebr@win.tue.nl> wrote:
>
> You propose to remove i_blksize.
> Yes, a good plan, half an hour's work.
> It is used in stat only, so we have to produce some value for stat.
> Do you want to replace
> inode->i_blksize
> by
> inode->i_sb->s_optimal_io_size
> ?
No, that's different. You are referring to stat.st_blksize. That is a
different animal, and we can leave that alone.
inode->i_blksize is equal to (1 << inode->i_blkbits) always, all the time.
It is just duplicated nonsense and usually leads to poorer code -
multiplications instead of shifts.
It should be a pretty easy incremental set of patches to ease i_blksize out
of the kernel.
next prev parent reply other threads:[~2003-08-05 6:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-04 2:03 do_div considered harmful Andries.Brouwer
2003-08-04 2:29 ` Andrew Morton
2003-08-05 2:58 ` i_blksize Andries Brouwer
2003-08-05 6:10 ` Andrew Morton [this message]
2003-08-04 5:54 ` do_div considered harmful Linus Torvalds
2003-08-05 9:20 i_blksize Andries.Brouwer
2003-08-05 15:55 ` i_blksize Andrew Morton
2003-08-05 16:27 i_blksize Andries.Brouwer
2003-08-05 17:50 ` i_blksize Andrew Morton
2003-08-05 18:09 ` i_blksize Andreas Dilger
2003-08-05 19:48 i_blksize Andries.Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030804231026.0d7251f2.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=Andries.Brouwer@cwi.nl \
--cc=aebr@win.tue.nl \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®