From: Andi Kleen <ak@colin2.muc.de>
To: Andrew Morton <akpm@osdl.org>
Cc: Andi Kleen <ak@muc.de>, torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Export touch_nmi_watchdog
Date: 5 Aug 2003 22:08:10 +0200 [thread overview]
Date: Tue, 5 Aug 2003 22:08:10 +0200 [thread overview]
Message-ID: <20030805200810.GA31598@colin2.muc.de> (raw)
In-Reply-To: <20030805123811.1fe61585.akpm@osdl.org>
On Tue, Aug 05, 2003 at 12:38:11PM -0700, Andrew Morton wrote:
> Andi Kleen <ak@muc.de> wrote:
> >
> > Sometimes drivers do long things with interrupt off and the NMI watchdog
> > triggers quickly. This mostly happens in error handling. It would be
> > better to fix the drivers to sleep in this case, but it's not always
> > possible or too much work.
>
> yup.
>
> Do we need an mdelay_while_touching_nmi_watchdog() variant?
Maybe that would be too encoraging for broken code.
Admittedly I did that by hand for the MPT fusion driver (which currently
triggers the watchdog when it gets into any error handling situation)
This especially hurts on x86-64 which runs the watchdog by default.
But it's strictly a bad hack, not a good interface.
-Andi
next prev parent reply other threads:[~2003-08-05 20:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-05 19:29 Andi Kleen
2003-08-05 19:38 ` Andrew Morton
2003-08-05 20:08 ` Andi Kleen [this message]
2003-08-05 20:20 ` Arjan van de Ven
2003-08-05 20:25 ` Linus Torvalds
2003-08-05 20:31 ` Arjan van de Ven
2003-08-05 21:07 ` Linus Torvalds
2003-08-05 21:05 ` Tim Hockin
2003-08-05 21:14 ` Andi Kleen
2003-08-05 21:15 ` Arjan van de Ven
2003-08-05 21:19 ` Andi Kleen
2003-08-05 22:14 ` Linus Torvalds
2003-08-06 0:07 ` Andi Kleen
2003-08-06 11:06 ` Ingo Oeser
2003-08-06 15:31 ` Linus Torvalds
2003-08-05 20:45 ` Andi Kleen
2003-08-05 21:11 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030805200810.GA31598@colin2.muc.de \
--to=ak@colin2.muc.de \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®