mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomas Szepe <szepe@pinerecords.com>
To: alan@lxorguk.ukuu.org.uk
Cc: lkml <linux-kernel@vger.kernel.org>
Subject: [PATCH] clarify why DMA gets disabled on broken drives
Date: Tue, 5 Aug 2003 23:29:18 +0200	[thread overview]
Message-ID: <20030805212918.GB22909@louise.pinerecords.com> (raw)

Alan,

I just ran into this and had to look at the sources to find out why
the IDE driver was turning off DMA for a particular drive.

(It's nice to see that this actually works, btw. 8))

- 
Tomas Szepe <szepe@pinerecords.com>

Patch against 2.4.22-rc1.

diff -urN a/drivers/ide/ide-dma.c b/drivers/ide/ide-dma.c
--- a/drivers/ide/ide-dma.c	2003-08-05 23:20:48.000000000 +0200
+++ b/drivers/ide/ide-dma.c	2003-08-05 23:24:22.000000000 +0200
@@ -835,7 +835,8 @@
 #ifdef CONFIG_IDEDMA_NEW_DRIVE_LISTINGS
 	int blacklist = in_drive_list(id, drive_blacklist);
 	if (blacklist) {
-		printk("%s: Disabling (U)DMA for %s\n", drive->name, id->model);
+		printk("%s: Disabling (U)DMA for %s (on blacklist)\n",
+			drive->name, id->model);
 		return(blacklist);
 	}
 #else /* !CONFIG_IDEDMA_NEW_DRIVE_LISTINGS */
@@ -844,7 +845,7 @@
 	list = bad_dma_drives;
 	while (*list) {
 		if (!strcmp(*list++,id->model)) {
-			printk("%s: Disabling (U)DMA for %s\n",
+			printk("%s: Disabling (U)DMA for %s (on blacklist)\n",
 				drive->name, id->model);
 			return 1;
 		}

                 reply	other threads:[~2003-08-05 21:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030805212918.GB22909@louise.pinerecords.com \
    --to=szepe@pinerecords.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®