Re: Re 2.6.0-test2-mm4

[Andrew Morton <akpm@osdl.org>]

Florent Coste <coste.florent@free.fr> wrote:
>
> - test2-mm2 :  pppd starts ok (i use & follow 2.5.x & 2.6-test branch 
>  since ~2.5.40 .... 2.5.72-mm2 was ok for instance)
>  - test2-mm3-1 : pppd does not start, kobject badness trace, full traces 
>  in my last email and parts above :

The `badness' thing is just telling us that netdevices aren't fully up to
speed with the kobject layer yet.  Don't worry about that.

As for the ppp problem: don't know, sorry.  There was a small change in ppp
between those two kernel versions, so it would be useful if you could do a
`patch -R' of the below, see if that fixes mm3-1.  Thanks.

diff -Nru a/drivers/char/tty_io.c b/drivers/char/tty_io.c
--- a/drivers/char/tty_io.c	Wed Aug  6 14:30:49 2003
+++ b/drivers/char/tty_io.c	Wed Aug  6 14:30:49 2003
@@ -611,6 +611,8 @@
 		(tty->driver->stop)(tty);
 }
 
+EXPORT_SYMBOL(stop_tty);
+
 void start_tty(struct tty_struct *tty)
 {
 	if (!tty->stopped || tty->flow_stopped)
@@ -628,6 +630,8 @@
 		(tty->ldisc.write_wakeup)(tty);
 	wake_up_interruptible(&tty->write_wait);
 }
+
+EXPORT_SYMBOL(start_tty);
 
 static ssize_t tty_read(struct file * file, char * buf, size_t count, 
 			loff_t *ppos)
diff -Nru a/drivers/net/ppp_async.c b/drivers/net/ppp_async.c
--- a/drivers/net/ppp_async.c	Wed Aug  6 14:30:49 2003
+++ b/drivers/net/ppp_async.c	Wed Aug  6 14:30:49 2003
@@ -891,6 +891,11 @@
 			process_input_packet(ap);
 		} else if (c == PPP_ESCAPE) {
 			ap->state |= SC_ESCAPE;
+		} else if (I_IXON(ap->tty)) {
+			if (c == START_CHAR(ap->tty))
+				start_tty(ap->tty);
+			else if (c == STOP_CHAR(ap->tty))
+				stop_tty(ap->tty);
 		}
 		/* otherwise it's a char in the recv ACCM */
 		++n;