mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: 2.6.0-test2-mm5 working on ppc
Date: Thu, 7 Aug 2003 17:05:18 -0700	[thread overview]
Message-ID: <20030807170518.05155923.akpm@osdl.org> (raw)
In-Reply-To: <16178.56121.743989.77396@cargo.ozlabs.ibm.com>

Paul Mackerras <paulus@samba.org> wrote:
>
> This patch gets 2.6.0-test2-mm5 to boot on my G3 powerbook.  The first
> problem was that we had dev_t in struct stat, thus userland became
> unhappy when dev_t changed size.

OK.

> The second problem was that sys_mknod got changed to take an unsigned
> int rather than a dev_t, but we were still calling it with a dev_t
> argument in init/do_mounts.h and init/initramfs.c.  That might sorta
> work on x86 but it doesn't on ppc.  My solution to that is to export
> and use do_mknod instead.

Well yes.  The reason for this problem is that people keep on putting
function prototypes into .c files.

I might add that the major sinners are maintainers of non-ia32
architectures.

>  Of course the do_mknod prototype should
> really go in a header somewhere but I was too lazy to do that.

I'll find somewhere to tuck it.  Thanks for working all that out.


      reply	other threads:[~2003-08-08  0:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-07 23:05 Paul Mackerras
2003-08-08  0:05 ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030807170518.05155923.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®