mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: Greg KH <greg@kroah.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-kernel@vger.kernel.org
Subject: Re: devinit
Date: Thu, 7 Aug 2003 13:26:58 -0700	[thread overview]
Message-ID: <20030807202658.GD579@ip68-0-152-218.tc.ph.cox.net> (raw)
In-Reply-To: <20030806233103.GA8497@kroah.com>

[-- Attachment #1: Type: text/plain, Size: 2927 bytes --]

On Wed, Aug 06, 2003 at 04:31:03PM -0700, Greg KH wrote:

> On Wed, Aug 06, 2003 at 07:21:23PM -0400, Jeff Garzik wrote:
> > Greg KH wrote:
> > >I've applied the 2.6 patch to my trees and will send it on to Linus in a
> > >few days, thanks.
> > 
> > 
> > Speaking of PCI... are we gonna have to zap __devinit too?  Another 
> > option is to think of add-new-pci-ids-on-the-fly as a CONFIG_HOTPLUG 
> > feature, which should(?) maintain the current __devinit semantics: no 
> > re-probes.
> 
> Yeah, that option does break almost all current usages of __devinit* in
> pci drivers today with CONFIG_HOTPLUG disabled :(
> 
> So either making it a different config option, or just dropping
> __devinit* all together is fine with me, one of them needs to happen.
> 
> Any preferences from anyone else?

Make it an option.

> > OTOH, __devinit already is a no-op for CONFIG_HOTPLUG cases (read: most 
> > everybody), so I wonder if we care enough about __devinit anymore?  I 
> > used the same logic to support __devinitdata removal, after all.
> 
> If we drop __devinit* then having CONFIG_HOTPLUG as a config option is
> almost pointless as it doesn't really affect much code at all.  Any
> objections to just always enabling it?
> 
> Anyone want to make up any before and after memory usages with
> CONFIG_HOTPLUG enabled and disabled to see if it's really as small as
> I'm thinking it is?  

Well, here's some numbers I came up with on 2.6.0-test2 on PPC.  I
picked 3 boards, EmbeddedPlanet 8260, IBM Spruce and IBM Walnut, made
the vmlinux (with an occasional fix here and there for other issues),
and came up with the following size changes (see arch/ppc/configs/ for
the base config).  From HOTPLUG=n to HOTPLUG=y, and with __devinit stuff
put in it's own section I got:
EmbeddedPlanet 8260 (PPC8260, CONFIG_PCI==n):
.text: +2580
.exit.text: same
.rodata: +104
__ksymtab: same
.data: +352
.init.text (excluding __devinit): same.
.init.dev.text: 1692.
.init.data vs .init.data: 84

IBM Spruce (PPC750):
.text: +18528
.exit.text: -300
.rodata: +956
__ksymstab: +96
.data: +6816
.init.text (excluding __devinit): +132
.init.dev.text: 13032

IBM Walnut (PPC405):
.text: +17648
.exit.text: -300
.rodata: +1288
__ksymstab: +96
.data: +5312
.init.text (excluding __devinit): +128
.init.dev.text: 10508

The 8260 board is almost all 'custom' drivers inside of arch/ppc (long
story) and don't make much use of __init-style markups.  The other
boards make use of more standard drivers, and have PCI.  Since this is
-test2, and not current BK I'm not sure how correct the .data figures
are now, but it looks like CONFIG_HOTPLUG adds ~13kB to a kernel.  So
how about stubbing things out if that makes it easier to code up hotplug
stuff (which can be important on some embedded devices too) so there's
choice?

-- 
Tom Rini
http://gate.crashing.org/~trini/

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2003-08-07 20:27 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-06 19:54 [PATCH] trivial 2.4/2.6 PCI name change/addition Alex Williamson
2003-08-06 22:13 ` Bjorn Helgaas
2003-08-07 12:05   ` Marcelo Tosatti
2003-08-07 12:32   ` Marcelo Tosatti
2003-08-07 15:52     ` Bjorn Helgaas
2003-08-06 23:09 ` Greg KH
2003-08-06 23:21   ` devinit Jeff Garzik
2003-08-06 23:31     ` devinit Greg KH
2003-08-07 20:26       ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030807202658.GD579@ip68-0-152-218.tc.ph.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=greg@kroah.com \
    --cc=jgarzik@pobox.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®