From: Muli Ben-Yehuda <mulix@mulix.org>
To: Marcelo Tosatti <marcelo@conectiva.com.br>
Cc: Linux-Kernel <linux-kernel@vger.kernel.org>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Muli Ben-Yehuda <mulix@mulix.org>
Subject: [PATCH] fix trident.c lockup on module load 2.4.22-rc1
Date: Sun, 10 Aug 2003 00:25:03 +0300 [thread overview]
Message-ID: <20030809212502.GQ12446@actcom.co.il> (raw)
[-- Attachment #1: Type: text/plain, Size: 959 bytes --]
Hi Marcelo,
This patch fixes a kernel lockup with 2.4.22-rc1 when the trident.c
driver is loaded and the driver attempts to initialize the card. The
problem is that in ali_ac97_get() we lock the card->lock spinlock, but
never release it on the good path, only on the error path. This patch
adds the missing spin_unlock_irqrestore().
Patch is against 2.4.22-rc1-cvs, tested and works, and fixes a pretty
severe lockup bug. Please apply.
Cheers,
Muli.
Index: drivers/sound/trident.c
===================================================================
RCS file: /home/cvs/linux-2.4/drivers/sound/trident.c,v
retrieving revision 1.29
diff -u -r1.29 trident.c
--- drivers/sound/trident.c 2 Jul 2003 21:42:15 -0000 1.29
+++ drivers/sound/trident.c 9 Aug 2003 19:54:58 -0000
@@ -3014,6 +3014,8 @@
}
data = inl(TRID_REG(card, address));
+
+ spin_unlock_irqrestore(&card->lock, flags);
return ((u16) (data >> 16));
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
reply other threads:[~2003-08-09 21:25 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030809212502.GQ12446@actcom.co.il \
--to=mulix@mulix.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®