From: Francois Romieu <romieu@fr.zoreil.com>
To: davej@redhat.com
Cc: torvalds@osdl.org, linux-kernel@vger.kernel.org, jgarzik@pobox.com
Subject: Re: [PATCH] Missing spin_unlock_irqrestore from rrunner driver.
Date: Mon, 11 Aug 2003 20:11:48 +0200 [thread overview]
Message-ID: <20030811201148.A1246@electric-eye.fr.zoreil.com> (raw)
In-Reply-To: <E19mF4Z-0005Ep-00@tetrachloride>; from davej@redhat.com on Mon, Aug 11, 2003 at 04:59:03PM +0100
davej@redhat.com <davej@redhat.com> :
> diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/net/rrunner.c linux-2.5/drivers/net/rrunner.c
> --- bk-linus/drivers/net/rrunner.c 2003-08-04 01:00:27.000000000 +0100
> +++ linux-2.5/drivers/net/rrunner.c 2003-08-06 18:59:37.000000000 +0100
> @@ -1645,6 +1645,7 @@ static int rr_ioctl(struct net_device *d
> printk(KERN_ERR "%s: Error reading EEPROM\n",
> dev->name);
> error = -EFAULT;
> + spin_unlock_irqrestore(&rrpriv->lock, flags);
> goto gf_out;
> }
> spin_unlock_irqrestore(&rrpriv->lock, flags);
> -
Bloat :o)
--- linux-2.6.0-test3/drivers/net/rrunner.c Mon Aug 11 20:03:21 2003
+++ linux-2.6.0-test3/drivers/net/rrunner.c Mon Aug 11 20:03:38 2003
@@ -1641,13 +1641,13 @@ static int rr_ioctl(struct net_device *d
spin_lock_irqsave(&rrpriv->lock, flags);
i = rr_read_eeprom(rrpriv, 0, image, EEPROM_BYTES);
+ spin_unlock_irqrestore(&rrpriv->lock, flags);
if (i != EEPROM_BYTES){
printk(KERN_ERR "%s: Error reading EEPROM\n",
dev->name);
error = -EFAULT;
goto gf_out;
}
- spin_unlock_irqrestore(&rrpriv->lock, flags);
error = copy_to_user(rq->ifr_data, image, EEPROM_BYTES);
if (error)
error = -EFAULT;
next prev parent reply other threads:[~2003-08-11 18:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-11 15:59 davej
2003-08-11 18:11 ` Francois Romieu [this message]
2003-08-11 18:22 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030811201148.A1246@electric-eye.fr.zoreil.com \
--to=romieu@fr.zoreil.com \
--cc=davej@redhat.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®