From: Andries Brouwer <aebr@win.tue.nl>
To: Jeff Woods <kazrak+kernel@cesmail.net>
Cc: Andries Brouwer <aebr@win.tue.nl>,
linux-scsi@vger.kernel.org,
linux-usb-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] oops in sd_shutdown
Date: Tue, 12 Aug 2003 04:49:01 +0200 [thread overview]
Message-ID: <20030812044901.A1650@pclin040.win.tue.nl> (raw)
In-Reply-To: <5.2.1.1.0.20030811180413.01a67dc0@no.incoming.mail>; from kazrak+kernel@cesmail.net on Mon, Aug 11, 2003 at 06:13:50PM -0700
On Mon, Aug 11, 2003 at 06:13:50PM -0700, Jeff Woods wrote:
> Looking only at the above code snippet, I'd suggest something more like:
> + if (!sdp ||
This is not meaningful.
A general kind of convention is that a pointer will be NULL either
by mistake, when it is uninitialized, or on purpose, when no object
is present or no action (other than the default) needs to be performed.
But that general idea is broken by container_of(), which just subtracts
a constant. So, one should check before subtracting that the pointer
is non-NULL. Checking afterwards is meaningless.
next prev parent reply other threads:[~2003-08-12 2:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <Pine.LNX.4.53.0308111426570.16008@thevillage.soulcatcher>
2003-08-11 22:28 ` Andries Brouwer
2003-08-12 1:13 ` Jeff Woods
2003-08-12 2:49 ` Andries Brouwer [this message]
2003-08-12 6:35 ` Jeff Woods
2003-08-12 21:36 ` [linux-usb-devel] " Greg KH
2003-08-12 6:53 ` Christoph Hellwig
2003-08-12 8:51 ` Andries Brouwer
2003-08-12 21:35 ` [linux-usb-devel] " Greg KH
2003-08-13 0:24 ` Mike Anderson
2003-08-13 10:46 ` Andries Brouwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030812044901.A1650@pclin040.win.tue.nl \
--to=aebr@win.tue.nl \
--cc=kazrak+kernel@cesmail.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®