From: Andi Kleen <ak@suse.de>
To: Zwane Mwaikambo <zwane@linuxpower.ca>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
William Lee Irwin III <wli@holomorphy.com>,
Andi Kleen <ak@suse.de>
Subject: Re: [PATCH][2.6-mm] cpumask_t - ioapic set_ioapic_affinity
Date: Tue, 12 Aug 2003 16:52:23 +0200 [thread overview]
Message-ID: <20030812145223.GA18538@wotan.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.53.0308120138400.26153@montezuma.mastecende.com>
> -static void set_ioapic_affinity (unsigned int irq, unsigned long mask)
> +static void set_ioapic_affinity (unsigned int irq, cpumask_t mask)
> {
> unsigned long flags;
> + unsigned int dest;
> +
> + dest = cpu_mask_to_apicid(mk_cpumask_const(mask));
> +
> /*
> * Only the first 8 bits are valid.
> */
> - mask = mask << 24;
> + dest = dest << 24;
>
> spin_lock_irqsave(&ioapic_lock, flags);
> - __DO_ACTION(1, = mask, )
> + __DO_ACTION(1, = dest, )
> spin_unlock_irqrestore(&ioapic_lock, flags);
Looks ok.
-Andi
prev parent reply other threads:[~2003-08-12 14:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-12 5:43 Zwane Mwaikambo
2003-08-12 14:52 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030812145223.GA18538@wotan.suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=wli@holomorphy.com \
--cc=zwane@linuxpower.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®