From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andries Brouwer <aebr@win.tue.nl>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ide: limit drive capacity to 137GB if host doesn't support LBA48
Date: Thu, 14 Aug 2003 14:48:27 +0200 [thread overview]
Message-ID: <200308141448.27905.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <1060851207.5535.15.camel@dhcp23.swansea.linux.org.uk>
On Thursday 14 of August 2003 10:53, Alan Cox wrote:
> On Iau, 2003-08-14 at 02:24, Bartlomiej Zolnierkiewicz wrote:
> > hwif->rqsize = old_hwif.rqsize;
> > - hwif->addressing = old_hwif.addressing;
> > + hwif->no_lba48 = old_hwif.no_lba48;
>
> This change is a bad idea. Its called "addressing" because that is what
> it is about (see SATA and ATA specs). In future SATA addressing becomes
> a 0,1,2 value because 48bits isnt enough, it may get more forms beyond
> that.
Its hwif->addressing not drive->addressing. Look at the current usage.
It is 1 when host doesn't support LBA48, otherwise its 0. We can add "real"
hwif->addressing when needed. IDE driver is already full of unfinished,
unused "features".
--bartlomiej
next prev parent reply other threads:[~2003-08-14 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-14 1:24 Bartlomiej Zolnierkiewicz
2003-08-14 8:53 ` Alan Cox
2003-08-14 9:16 ` Andries Brouwer
2003-08-14 9:18 ` Nick Piggin
2003-08-14 11:03 ` Alan Cox
2003-08-14 12:48 ` Bartlomiej Zolnierkiewicz [this message]
2003-08-14 13:44 ` Alan Cox
2003-08-14 15:14 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308141448.27905.bzolnier@elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=aebr@win.tue.nl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®