From: Andrew Morton <akpm@osdl.org>
To: Peter Osterlund <petero2@telia.com>
Cc: lists@runa.sytes.net, linux-kernel@vger.kernel.org, axboe@suse.de
Subject: Re: segfault when unloading module loop in 2.6.0-test3+ck patches
Date: Sun, 17 Aug 2003 13:59:35 -0700 [thread overview]
Message-ID: <20030817135935.2790cec6.akpm@osdl.org> (raw)
In-Reply-To: <m28yps57oi.fsf@p4.localdomain>
Peter Osterlund <petero2@telia.com> wrote:
>
> (I'm resending this because I previously had sendmail configuration
> problems. Sorry if you receive this message twice.)
I saw it (and the other) the first time, thanks.
> diff -puN drivers/block/loop.c~loop-oops-fix drivers/block/loop.c
> --- linux/drivers/block/loop.c~loop-oops-fix 2003-08-17 19:19:22.000000000 +0200
> +++ linux-petero/drivers/block/loop.c 2003-08-17 20:33:03.000000000 +0200
> @@ -1198,6 +1198,7 @@ int __init loop_init(void)
> lo->lo_queue = blk_alloc_queue(GFP_KERNEL);
> if (!lo->lo_queue)
> goto out_mem4;
> + init_timer(&lo->lo_queue->unplug_timer);
> disks[i]->queue = lo->lo_queue;
> init_MUTEX(&lo->lo_ctl_mutex);
> init_MUTEX_LOCKED(&lo->lo_sem);
This bit should be done in ll_rw_blk.c somewhere. Are you sure it is
necessary for loop?
next prev parent reply other threads:[~2003-08-17 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-17 7:27 Martin Sarsale
2003-08-17 20:51 ` Peter Osterlund
2003-08-17 20:59 ` Andrew Morton [this message]
2003-08-17 21:15 ` Peter Osterlund
2003-08-17 21:36 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030817135935.2790cec6.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lists@runa.sytes.net \
--cc=petero2@telia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®