From: Francesco Sportolari <francesco@unipg.it>
To: linux-kernel@vger.kernel.org
Cc: DiegoCG@teleline.es, alsa-devel@lists.sourceforge.net
Subject: [bug 1080] [PATCH] 2.6.0-t3: alsa driver snd-powermac doesn't work with tumbler chip on ibook2
Date: Sun, 17 Aug 2003 23:54:06 +0200 [thread overview]
Message-ID: <200308172354.06944.francesco@unipg.it> (raw)
During the insmod of the snd-powermac module this msg is printed to the
console:
tumbler: cannot initialize the MCS
After that, even if the module is loaded correctly, the sound doesn't work at
all.
I've noticed that removing and inserting again the 'i2c-keywest' module solves
the problem. The following patch fixes this issue related to early
initialization of the i2c client in the driver.
Bye,
-- Francesco
--- orig/sound/ppc/tumbler.c 2003-08-16 17:18:35.000000000 +0200
+++ linux-2.6.0-test3/sound/ppc/tumbler.c 2003-08-16 17:18:55.000000000
+0200
@@ -996,9 +996,6 @@
chipname = "Snapper";
}
- if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0)
- return err;
-
/*
* build mixers
*/
@@ -1025,6 +1022,9 @@
if ((err = tumbler_init(chip)) < 0)
return err;
+ if ((err = snd_pmac_keywest_init(&mix->i2c)) < 0)
+ return err;
+
#ifdef CONFIG_PMAC_PBOOK
chip->resume = tumbler_resume;
#endif
reply other threads:[~2003-08-17 19:54 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308172354.06944.francesco@unipg.it \
--to=francesco@unipg.it \
--cc=DiegoCG@teleline.es \
--cc=alsa-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®