From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261297AbTHSWlY (ORCPT ); Tue, 19 Aug 2003 18:41:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261306AbTHSWlY (ORCPT ); Tue, 19 Aug 2003 18:41:24 -0400 Received: from twilight.ucw.cz ([81.30.235.3]:31140 "EHLO twilight.ucw.cz") by vger.kernel.org with ESMTP id S261297AbTHSWlU (ORCPT ); Tue, 19 Aug 2003 18:41:20 -0400 Date: Wed, 20 Aug 2003 00:41:04 +0200 From: Vojtech Pavlik To: "Pallipadi, Venkatesh" Cc: linux-kernel@vger.kernel.org, torvalds@osdl.org, "Nakajima, Jun" , "Mallick, Asit K" Subject: Re: [PATCH][2.6][5/5]Support for HPET based timer Message-ID: <20030819224104.GB13346@ucw.cz> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.4i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 19, 2003 at 12:20:22PM -0700, Pallipadi, Venkatesh wrote: > 5/5 - hpet5.patch - This can be a standalone patch. Without this > patch we loose interrupt generation capability > of RTC (/dev/rtc), due to HPET. With this patch > we basically try to emulate RTC interrupt > functions in software using HPET counter 1. > This is very wrong IMO. We shouldn't try to emulate the RTC interrupt for the kernel, instead the HPET should use native APIC interrupt routing. This way the RTC will keep working and the 'legacy mode' of HPET doesn't need to be used. I must admit I was a bit lazy when I was implementing the x86_64 variant and the native IRQ for HPET is still on my to-do list. -- Vojtech Pavlik SuSE Labs, SuSE CR