mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: venkatesh.pallipadi@intel.com, vojtech@suse.cz, ak@suse.de,
	haveblue@us.ibm.com, mikpe@csd.uu.se, jun.nakajima@intel.com,
	suresh.b.siddha@intel.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH][2.6][2/5]Support for HPET based timer
Date: Tue, 26 Aug 2003 11:55:53 -0700	[thread overview]
Message-ID: <20030826115553.7f8b3285.akpm@osdl.org> (raw)
In-Reply-To: <20030826115129.509c4161.akpm@osdl.org>

Andrew Morton <akpm@osdl.org> wrote:
>
> I doubt if we really need the timer running that early, apart from for
>  calibrate_delay().
> 
>  You can probably move the time_init() and calibrate_delay() so they occur
>  after mem_init().  A close review would be needed to see if that is likely
>  to break anything.  If it is, then consider creating a new late_time_init()
>  thing, and call that and calibrate_delay() after mem_init().
> 

Actually, I think some platforms (ppc64) will explode if we do the
local_irq_enable() prior to time_init().

So I suggest you look at the latter option:

- change time_init() so that it doesn't actually touch the HPET hardware
  in the HPET timer case.

- add late_time_init() after mem_init().

- then do calibrate_delay().

Or whatever.  The bottom line is that init/main.c is fragile, but not
inviolable ;)



  reply	other threads:[~2003-08-26 19:55 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-08-26 18:31 Pallipadi, Venkatesh
2003-08-26 18:51 ` Andrew Morton
2003-08-26 18:55   ` Andrew Morton [this message]
2003-08-26 23:20     ` john stultz
  -- strict thread matches above, loose matches on Subject: below --
2003-08-26 23:50 Pallipadi, Venkatesh
2003-08-26 21:43 Mikael Pettersson
2003-08-20 17:01 Pallipadi, Venkatesh
     [not found] <C8C38546F90ABF408A5961FC01FDBF1902C7D1C9@fmsmsx405.fm.intel.com.suse.lists.linux.kernel>
     [not found] ` <20030820080513.GB17793@ucw.cz.suse.lists.linux.kernel>
2003-08-20 10:01   ` Andi Kleen
2003-08-20 10:47     ` Mikael Pettersson
2003-08-20 17:09     ` Dave Hansen
2003-08-20  1:30 Pallipadi, Venkatesh
2003-08-20  0:18 Pallipadi, Venkatesh
2003-08-20  8:05 ` Vojtech Pavlik
     [not found] <mmZK.Q4.11@gated-at.bofh.it>
2003-08-19 22:41 ` Andi Kleen
2003-08-19 19:20 Pallipadi, Venkatesh
2003-08-19 22:39 ` Vojtech Pavlik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20030826115553.7f8b3285.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@suse.de \
    --cc=haveblue@us.ibm.com \
    --cc=jun.nakajima@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mikpe@csd.uu.se \
    --cc=suresh.b.siddha@intel.com \
    --cc=venkatesh.pallipadi@intel.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®