From: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Jan Niehusmann <jan@gondor.com>,
Marcelo Tosatti <marcelo@conectiva.com.br>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: Promise IDE patches
Date: Wed, 27 Aug 2003 17:20:06 +0200 [thread overview]
Message-ID: <200308271720.06382.bzolnier@elka.pw.edu.pl> (raw)
In-Reply-To: <1061996391.22825.39.camel@dhcp23.swansea.linux.org.uk>
On Wednesday 27 of August 2003 16:59, Alan Cox wrote:
> On Maw, 2003-08-26 at 23:54, Bartlomiej Zolnierkiewicz wrote:
> > Thanks Jan.
> >
> > Marcelo can you apply these patches?
>
> The first one of these is wrong too. It'll stop some people from
> being able to access existing file systems. This has to be fixed
> properly (in both 2.4 and 2.6) to distinguish between
> "Can PIO LBA48" "Can DMA LBA48" and "no LBA48". The latter being
> basically non existant.
>
> If you fail to do this then existing PIO LBA48 setups will just die
> on boot.
Alan, its not true. Please check with ide-disk.c.
If hwif->addressing is 1 then probe_lba_addressing() wont set
drive->addressing to 1 and therefore you wont get LBA48
(both PIO and DMA) because of drive->addressing check
insided __ide_do_rw_disk().
Its not complete fix but it doesnt break anything and stops fs corruption.
--bartlomiej
next prev parent reply other threads:[~2003-08-27 15:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-08-26 22:31 Jan Niehusmann
2003-08-26 22:54 ` Bartlomiej Zolnierkiewicz
2003-08-27 14:58 ` Alan Cox
2003-08-27 15:21 ` Bartlomiej Zolnierkiewicz
2003-08-27 14:59 ` Alan Cox
2003-08-27 15:12 ` Jan Niehusmann
2003-08-27 15:20 ` Jan Niehusmann
2003-08-27 15:45 ` Alan Cox
2003-08-27 15:20 ` Bartlomiej Zolnierkiewicz [this message]
2003-10-19 13:17 ` Jan Niehusmann
2003-08-27 1:26 Erik Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200308271720.06382.bzolnier@elka.pw.edu.pl \
--to=b.zolnierkiewicz@elka.pw.edu.pl \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jan@gondor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®